Bug 43885

Summary:

Remove obsolete WebGLArray type names

Product:

WebKit

Reporter:

Kenneth Russell <kbr>

Component:

WebGL

Assignee:

Kenneth Russell <kbr>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarrin, dglazkov, oliver, zmo

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	levin: review+, kbr: commit-queue-

Description Kenneth Russell 2010-08-11 15:49:13 PDT

The array-like types introduced along with WebGL such as Float32Array were split off into a separate specification a few months ago, and the type names changed from WebGL<T>Array to <T>Array. Compatibility code was left in place, but at this point, because the introduction of the shader validator will require content to be updated, it should be deleted.

Comment 1 Kenneth Russell 2010-08-11 15:49:44 PDT

*** Bug 43886 has been marked as a duplicate of this bug. ***

Comment 2 Kenneth Russell 2010-08-11 15:56:46 PDT

Created attachment 64173 [details]
Patch

From the ChangeLog:

Deleted aliases to obsolete WebGLArray type names. Updated affected layout tests, synchronizing them with the versions in the Khronos repository where appropriate. Ran all layout tests.

Comment 3 Kenneth Russell 2010-08-11 17:07:44 PDT

Note: patch above missed needed deletion of custom getters in V8DOMWindowCustom.cpp, to be fixed in the final commit.

Comment 4 Kenneth Russell 2010-08-11 17:12:49 PDT

Committed r65200: <http://trac.webkit.org/changeset/65200>