Bug 43885 - Remove obsolete WebGLArray type names
Summary: Remove obsolete WebGLArray type names
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
: 43886 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-08-11 15:49 PDT by Kenneth Russell
Modified: 2010-08-11 17:12 PDT (History)
4 users (show)

See Also:

Attachments
Patch (114.51 KB, patch)
2010-08-11 15:56 PDT, Kenneth Russell 		levin: review+
kbr: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-08-11 15:49:13 PDT 
The array-like types introduced along with WebGL such as Float32Array were split off into a separate specification a few months ago, and the type names changed from WebGL<T>Array to <T>Array. Compatibility code was left in place, but at this point, because the introduction of the shader validator will require content to be updated, it should be deleted.
Comment 1 Kenneth Russell 2010-08-11 15:49:44 PDT 
*** Bug 43886 has been marked as a duplicate of this bug. ***
Comment 2 Kenneth Russell 2010-08-11 15:56:46 PDT 
Created attachment 64173 [details]
Patch

From the ChangeLog:

Deleted aliases to obsolete WebGLArray type names. Updated affected layout tests, synchronizing them with the versions in the Khronos repository where appropriate. Ran all layout tests.
Comment 3 Kenneth Russell 2010-08-11 17:07:44 PDT 
Note: patch above missed needed deletion of custom getters in V8DOMWindowCustom.cpp, to be fixed in the final commit.
Comment 4 Kenneth Russell 2010-08-11 17:12:49 PDT 
Committed r65200: <http://trac.webkit.org/changeset/65200>