WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
43885
Remove obsolete WebGLArray type names
https://bugs.webkit.org/show_bug.cgi?id=43885
Summary
Remove obsolete WebGLArray type names
Kenneth Russell
Reported
2010-08-11 15:49:13 PDT
The array-like types introduced along with WebGL such as Float32Array were split off into a separate specification a few months ago, and the type names changed from WebGL<T>Array to <T>Array. Compatibility code was left in place, but at this point, because the introduction of the shader validator will require content to be updated, it should be deleted.
Attachments
Patch
(114.51 KB, patch)
2010-08-11 15:56 PDT
,
Kenneth Russell
levin
: review+
kbr
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kenneth Russell
Comment 1
2010-08-11 15:49:44 PDT
***
Bug 43886
has been marked as a duplicate of this bug. ***
Kenneth Russell
Comment 2
2010-08-11 15:56:46 PDT
Created
attachment 64173
[details]
Patch From the ChangeLog: Deleted aliases to obsolete WebGLArray type names. Updated affected layout tests, synchronizing them with the versions in the Khronos repository where appropriate. Ran all layout tests.
Kenneth Russell
Comment 3
2010-08-11 17:07:44 PDT
Note: patch above missed needed deletion of custom getters in V8DOMWindowCustom.cpp, to be fixed in the final commit.
Kenneth Russell
Comment 4
2010-08-11 17:12:49 PDT
Committed
r65200
: <
http://trac.webkit.org/changeset/65200
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug