Bug 43866

Summary:

The #if clause enabling a feature should avoid the all includes of the feature

Product:

WebKit

Reporter:

Alejandro G. Castro <alex>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Bug Depends on:

Bug Blocks:

42266

Attachments:

Description	Flags
Proposed patch	levin: review+

Alejandro G. Castro

Reported 2010-08-11 12:21:54 PDT

In this moment we are generating code like this: ... #include "config.h" #include "MathMLElementFactory.h" #include "MathMLNames.h" #if ENABLE(MATHML) #include "MathMLMathElement.h" #include "MathMLInlineContainerElement.h" #include "MathMLTextElement.h" #include "MathMLElement.h" #include <wtf/HashMap.h> ... This causes problems when you disable a feature because the includes add the symbols from the .h which are going to be undefined when you try to link the library, in gtk it fails linking our unit tests. To solve this issue we could generate something like this: ... #include "config.h" #if ENABLE(MATHML) #include "MathMLElementFactory.h" #include "MathMLNames.h" #include "MathMLMathElement.h" #include "MathMLInlineContainerElement.h" #include "MathMLTextElement.h" #include "MathMLElement.h" #include <wtf/HashMap.h> ...

Attachments
Proposed patch (1.23 KB, patch) 2010-08-11 12:23 PDT, Alejandro G. Castro	levin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alejandro G. Castro

Comment 1 2010-08-11 12:23:50 PDT

Created attachment 64146 [details] Proposed patch

Alejandro G. Castro

Comment 2 2010-08-12 01:07:21 PDT

Landed r65223

Lucas Forschler

Comment 3 2019-02-06 09:02:50 PST

Mass moving XML DOM bugs to the "DOM" Component.

Note You need to log in before you can comment on or make changes to this bug.