Summary: | [Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antonio Gomes <tonikitoo> | ||||
Component: | Tools / Tests | Assignee: | Antonio Gomes <tonikitoo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | hausmann | ||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Bug Depends on: | 43851 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Antonio Gomes
2010-08-11 07:44:33 PDT
Created attachment 64114 [details] (committed with r65165, r=ariya) patch v1 LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly. It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected to slots at all. Patch addresses the problem. Wrongly pressed a button. Reopening... Comment on attachment 64114 [details] (committed with r65165, r=ariya) patch v1 LGMT with the change to qobject_cast. Comment on attachment 64114 [details] (committed with r65165, r=ariya) patch v1 Clearing flags on attachment: 64114 Committed r65165: <http://trac.webkit.org/changeset/65165> (In reply to comment #3) > (From update of attachment 64114 [details]) > LGMT with the change to qobject_cast. Done. Thank you! |