Bug 43853

Summary: [Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
Product: WebKit Reporter: Antonio Gomes <tonikitoo>
Component: Tools / TestsAssignee: Antonio Gomes <tonikitoo>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on: 43851    
Bug Blocks:    
Attachments:
Description Flags
(committed with r65165, r=ariya) patch v1 none

Antonio Gomes
Reported 2010-08-11 07:44:33 PDT
When bug 43851 ([Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken) gets fixed, we also have to fix the way animatedRotation and animatedYRotation slots of WebViewGraphicsBased get connected and triggerred. Patch coming.
Attachments
(committed with r65165, r=ariya) patch v1 (4.65 KB, patch)
2010-08-11 07:52 PDT, Antonio Gomes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antonio Gomes
Comment 1 2010-08-11 07:52:44 PDT
Created attachment 64114 [details] (committed with r65165, r=ariya) patch v1 LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly. It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected to slots at all. Patch addresses the problem.
Antonio Gomes
Comment 2 2010-08-11 09:09:25 PDT
Wrongly pressed a button. Reopening...
Ariya Hidayat
Comment 3 2010-08-11 10:42:33 PDT
Comment on attachment 64114 [details] (committed with r65165, r=ariya) patch v1 LGMT with the change to qobject_cast.
Antonio Gomes
Comment 4 2010-08-11 11:30:59 PDT
Comment on attachment 64114 [details] (committed with r65165, r=ariya) patch v1 Clearing flags on attachment: 64114 Committed r65165: <http://trac.webkit.org/changeset/65165>
Antonio Gomes
Comment 5 2010-08-11 11:31:25 PDT
(In reply to comment #3) > (From update of attachment 64114 [details]) > LGMT with the change to qobject_cast. Done. Thank you!
Simon Hausmann
Comment 6 2010-08-12 04:42:32 PDT
Revision r65165 cherry-picked into qtwebkit-2.1 with commit 2b177d4a8faf94f5ff4326cb12db242af1230253
Note You need to log in before you can comment on or make changes to this bug.