|Summary:||[Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken|
|Product:||WebKit||Reporter:||Antonio Gomes <tonikitoo>|
|Component:||Tools / Tests||Assignee:||Antonio Gomes <tonikitoo>|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Description Antonio Gomes 2010-08-11 07:07:22 PDT
If one launches the QtTestBrowser in QWebView (default) mode, and switch to GraphicsView based mode (Developer->GraphicsView->Toggle use of Graphics View), it does not initializate a QGraphicsWebView mode, but a QWebView again. After that, all menus under Developer->GraphicsView gets activated but are *not* funcional, leading to crashes sometimes. Patch coming ...
Comment 1 Antonio Gomes 2010-08-11 07:23:15 PDT
Created attachment 64111 [details] patch v1 All window options data (including the bool holding if the view is either QWebView or QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow. When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were getting broken. Patch addresses this issue.
Comment 2 Early Warning System Bot 2010-08-11 07:29:22 PDT
Attachment 64111 [details] did not build on qt: Build output: http://queues.webkit.org/results/3752047
Comment 3 Antonio Gomes 2010-08-11 07:44:13 PDT
Created attachment 64113 [details] (committed with r65160, r=hausmann) patch v2 Same as patch v1 (attachment 64111 [details]) but fixed the build bustage. See comment #1 for summary.
Comment 4 Simon Hausmann 2010-08-11 08:05:30 PDT
Comment on attachment 64113 [details] (committed with r65160, r=hausmann) patch v2 r=me
Comment 5 Antonio Gomes 2010-08-11 09:02:43 PDT
Comment on attachment 64113 [details] (committed with r65160, r=hausmann) patch v2 Clearing flags on attachment: 64113 Committed r65160: <http://trac.webkit.org/changeset/r65160>