Bug 43835

Summary: [v8] Web Inspector: remove InjectDispatch.js
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, bweinstein, dglazkov, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Yury Semikhatsky
Reported 2010-08-11 01:07:19 PDT
Web Inspector: remove InjectDispatch.js now that all dispatching is done in generated native code.
Attachments
Patch (6.20 KB, patch)
2010-08-11 01:10 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2010-08-11 01:10:12 PDT
Created attachment 64085 [details] Patch
Pavel Feldman
Comment 2 2010-08-11 01:17:47 PDT
Comment on attachment 64085 [details] Patch WebKit/chromium/src/js/InjectDispatch.js:  + DevToolsAgentHost.dispatch(call, method); Should we remove this binding as well?
Yury Semikhatsky
Comment 3 2010-08-11 01:19:53 PDT
(In reply to comment #2) > (From update of attachment 64085 [details]) > WebKit/chromium/src/js/InjectDispatch.js:  > + DevToolsAgentHost.dispatch(call, method); > Should we remove this binding as well? It's already been removed.
WebKit Review Bot
Comment 4 2010-08-11 01:31:28 PDT
Attachment 64085 [details] did not build on chromium: Build output: http://queues.webkit.org/results/3725050
Yury Semikhatsky
Comment 5 2010-08-11 01:33:16 PDT
Comment on attachment 64085 [details] Patch Clearing flags on attachment: 64085 Committed r65136: <http://trac.webkit.org/changeset/65136>
Yury Semikhatsky
Comment 6 2010-08-11 01:33:27 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 7 2010-08-11 01:38:17 PDT
http://trac.webkit.org/changeset/65136 might have broken Chromium Linux Release
Note You need to log in before you can comment on or make changes to this bug.