| Summary: | [EFL] Add video files to enable video in WebKit EFL | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||
| Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | barbieri, commit-queue, eric.carlson, eric, kenneth, leandro, lucas.de.marchi | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 44098 | ||||||||
| Attachments: |
|
||||||||
|
Description
Gyuyoung Kim
2010-08-10 06:58:57 PDT
Created attachment 64009 [details]
Patch
Created attachment 64010 [details]
patch
There was coding style error. I fix it.
Comment on attachment 64010 [details]
patch
r=me
Comment on attachment 64010 [details] patch Rejecting patch 64010 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Last 500 characters of output: CommitQueue/LayoutTests Testing 20806 test cases. media/video-volume.html -> timed out Sampling process 87309 for 10 seconds with 10 milliseconds of run time between samples Sampling completed, processing symbols... Sample analysis of process 87309 written to file /Users/eseidel/Library/Logs/DumpRenderTree/HangReport.txt Exiting early after 1 failures. 17218 tests run. 697.74s total testing time 17217 test cases (99%) succeeded 1 test case (<1%) timed out 33 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/3765018 Hello eric, I don't know why layout test is failed by this patch. This patch doesn't enable VIDEO in WebKit EFL. Just add files regarding html5 video. You know, WebKit EFL doesn't have DRT yet. (But, Our engineer will contribute DRT soon.) I run the media/video-volume.html on EWebLauncher directly. There is no time-out. Could you let me know how to solve this problem ? Thanks. Comment on attachment 64010 [details]
patch
There seems to be some sort of problem on the bot.
This is the old "all media tests hang or crash" bug that we saw long ago. Which iirc was a CoreVideo bug which was fixed in a later version of quicktime. I'll look at the commit-bot this evening, but I believe it's a completely up-to-date leopard install. Comment on attachment 64010 [details] patch Clearing flags on attachment: 64010 Committed r65117: <http://trac.webkit.org/changeset/65117> All reviewed patches have been landed. Closing bug. |