Bug 43784

Summary: Make CSSSelector::specificity() non-recursive.
Product: WebKit Reporter: Hayato Ito <hayato>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 42806    
Attachments:
Description Flags
make-it-iterative none

Description Hayato Ito 2010-08-10 04:55:23 PDT
Please see the master bug for details.
https://bugs.webkit.org/show_bug.cgi?id=42806

We have to make CSSSelector::specificity() non-recursive in order to avoid stack overflow when a long CSS selector is used.
Comment 1 Hayato Ito 2010-08-10 05:23:00 PDT
Created attachment 64001 [details]
make-it-iterative
Comment 2 Kent Tamura 2010-08-10 22:02:30 PDT
Comment on attachment 64001 [details]
make-it-iterative

Looks good.
Comment 3 WebKit Commit Bot 2010-08-10 22:21:19 PDT
Comment on attachment 64001 [details]
make-it-iterative

Clearing flags on attachment: 64001

Committed r65123: <http://trac.webkit.org/changeset/65123>
Comment 4 WebKit Commit Bot 2010-08-10 22:21:23 PDT
All reviewed patches have been landed.  Closing bug.