Bug 43765

Summary: SegmentedString should keep track of how many characters it consumes
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 43746    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2010-08-09 20:02:16 PDT
SegmentedString should keep track of how many characters it consumes
Attachments
Patch (6.35 KB, patch)
2010-08-09 20:06 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-08-09 20:06:24 PDT
Created attachment 63967 [details] Patch
Adam Barth
Comment 2 2010-08-09 20:09:07 PDT
This facility will be used to implement view-source in Bug 43746.
Eric Seidel (no email)
Comment 3 2010-08-10 00:33:59 PDT
Comment on attachment 63967 [details] Patch This looks sane. I assume you perf tested this?
Adam Barth
Comment 4 2010-08-10 00:38:07 PDT
The pref testing shows a minor increase, either due to noise or improve use of cache lines.
WebKit Commit Bot
Comment 5 2010-08-10 16:47:19 PDT
Comment on attachment 63967 [details] Patch Clearing flags on attachment: 63967 Committed r65100: <http://trac.webkit.org/changeset/65100>
WebKit Commit Bot
Comment 6 2010-08-10 16:47:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.