Bug 43765 - SegmentedString should keep track of how many characters it consumes
Summary: SegmentedString should keep track of how many characters it consumes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 43746
  Show dependency tree / graph
 
Reported: 2010-08-09 20:02 PDT by Adam Barth
Modified: 2010-08-10 16:47 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.35 KB, patch)
2010-08-09 20:06 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-08-09 20:02:16 PDT 
SegmentedString should keep track of how many characters it consumes
Comment 1 Adam Barth 2010-08-09 20:06:24 PDT 
Created attachment 63967 [details]
Patch
Comment 2 Adam Barth 2010-08-09 20:09:07 PDT 
This facility will be used to implement view-source in Bug 43746.
Comment 3 Eric Seidel (no email) 2010-08-10 00:33:59 PDT 
Comment on attachment 63967 [details]
Patch

This looks sane.  I assume you perf tested this?
Comment 4 Adam Barth 2010-08-10 00:38:07 PDT 
The pref testing shows a minor increase, either due to noise or improve use of cache lines.
Comment 5 WebKit Commit Bot 2010-08-10 16:47:19 PDT 
Comment on attachment 63967 [details]
Patch

Clearing flags on attachment: 63967

Committed r65100: <http://trac.webkit.org/changeset/65100>
Comment 6 WebKit Commit Bot 2010-08-10 16:47:24 PDT 
All reviewed patches have been landed.  Closing bug.