Bug 43728

Summary: [Qt] No need for PageClientImpl
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch none

Description Balazs Kelemen 2010-08-09 09:54:42 PDT 
In http://trac.webkit.org/changeset/64122 I have created a PageClientImpl class by moving the WebKit::PageClient implementation from QWKPagePrivate to the new class. The reason of this change is written in bug 42974. However, after http://trac.webkit.org/changeset/64155 the new class has became useless. I think it would be better to take back the change by making QWKPagePrivate the PageClient since it is more logical.
Comment 1 Balazs Kelemen 2010-08-09 10:01:12 PDT 
Created attachment 63905 [details]
proposed patch
Comment 2 Eric Seidel (no email) 2010-08-09 11:01:35 PDT 
Comment on attachment 63905 [details]
proposed patch

Clearing flags on attachment: 63905

Committed r64992: <http://trac.webkit.org/changeset/64992>
Comment 3 Eric Seidel (no email) 2010-08-09 11:01:40 PDT 
All reviewed patches have been landed.  Closing bug.