Bug 43728

Summary: [Qt] No need for PageClientImpl
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch none

Balazs Kelemen
Reported 2010-08-09 09:54:42 PDT
In http://trac.webkit.org/changeset/64122 I have created a PageClientImpl class by moving the WebKit::PageClient implementation from QWKPagePrivate to the new class. The reason of this change is written in bug 42974. However, after http://trac.webkit.org/changeset/64155 the new class has became useless. I think it would be better to take back the change by making QWKPagePrivate the PageClient since it is more logical.
Attachments
proposed patch (3.76 KB, patch)
2010-08-09 10:01 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2010-08-09 10:01:12 PDT
Created attachment 63905 [details] proposed patch
Eric Seidel (no email)
Comment 2 2010-08-09 11:01:35 PDT
Comment on attachment 63905 [details] proposed patch Clearing flags on attachment: 63905 Committed r64992: <http://trac.webkit.org/changeset/64992>
Eric Seidel (no email)
Comment 3 2010-08-09 11:01:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.