Summary: | Web Inspector: remove InspectorFrontend | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yury Semikhatsky <yurys> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Yury Semikhatsky <yurys> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, bweinstein, dglazkov, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit-ews, webkit.review.bot, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Yury Semikhatsky
2010-08-09 09:03:59 PDT
Created attachment 63898 [details]
Patch
Created attachment 63899 [details]
Patch
Comment on attachment 63899 [details]
Patch
LayoutTests/http/tests/inspector/inspector-test.js:39
+ {
Nit: strange indentation.
LayoutTests/http/tests/inspector-enabled/resources/console-log-frame-after-navigation.html:5
+ setTimeout(function() {
Does not belong to this change.
WebCore/inspector/InspectorController.cpp:474
+ void InspectorController::connectFrontend(const ScriptObject&)
Remove this parameter as a whole? r- for this!
WebCore/inspector/InspectorController.cpp:478
+ m_remoteFrontend = new RemoteInspectorFrontend(m_client);
InspectorFrontend is dead. Long live InspectorFrontend.
In other words: let rename RemoteInspectorFrontend to InspectorFrontend!
Attachment 63898 [details] did not build on chromium: Build output: http://queues.webkit.org/results/3690060 Created attachment 63976 [details]
Patch
Addressed all comments. Attachment 63976 [details] did not build on qt: Build output: http://queues.webkit.org/results/3714013 http://trac.webkit.org/changeset/65053 might have broken Chromium Linux Release |