Bug 43726

Summary: Web Inspector: remove InspectorFrontend
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, bweinstein, dglazkov, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit-ews, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch pfeldman: review+

Yury Semikhatsky
Reported 2010-08-09 09:03:59 PDT
Web Inspector: remove InspectorFrontend
Attachments
Patch (19.53 KB, patch)
2010-08-09 09:06 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (18.89 KB, patch)
2010-08-09 09:09 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (20.47 KB, patch)
2010-08-09 22:51 PDT, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2010-08-09 09:06:51 PDT
Created attachment 63898 [details] Patch
Yury Semikhatsky
Comment 2 2010-08-09 09:09:35 PDT
Created attachment 63899 [details] Patch
Pavel Feldman
Comment 3 2010-08-09 09:14:52 PDT
Comment on attachment 63899 [details] Patch LayoutTests/http/tests/inspector/inspector-test.js:39 + { Nit: strange indentation. LayoutTests/http/tests/inspector-enabled/resources/console-log-frame-after-navigation.html:5 + setTimeout(function() { Does not belong to this change. WebCore/inspector/InspectorController.cpp:474 + void InspectorController::connectFrontend(const ScriptObject&) Remove this parameter as a whole? r- for this! WebCore/inspector/InspectorController.cpp:478 + m_remoteFrontend = new RemoteInspectorFrontend(m_client); InspectorFrontend is dead. Long live InspectorFrontend. In other words: let rename RemoteInspectorFrontend to InspectorFrontend!
WebKit Review Bot
Comment 4 2010-08-09 09:24:54 PDT
Attachment 63898 [details] did not build on chromium: Build output: http://queues.webkit.org/results/3690060
Yury Semikhatsky
Comment 5 2010-08-09 22:51:17 PDT
Created attachment 63976 [details] Patch
Yury Semikhatsky
Comment 6 2010-08-09 22:52:30 PDT
Addressed all comments.
Early Warning System Bot
Comment 7 2010-08-09 23:04:28 PDT
Attachment 63976 [details] did not build on qt: Build output: http://queues.webkit.org/results/3714013
WebKit Review Bot
Comment 8 2010-08-10 00:17:54 PDT
http://trac.webkit.org/changeset/65053 might have broken Chromium Linux Release
Yury Semikhatsky
Comment 9 2010-08-10 00:27:42 PDT
Committed r65053
Note You need to log in before you can comment on or make changes to this bug.