Bug 43695

Summary: [Qt] Inconsistent Qt version checks
Product: WebKit Reporter: Ariya Hidayat <ariya.hidayat>
Component: New BugsAssignee: Ariya Hidayat <ariya.hidayat>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Qt
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch tonikitoo: review+

Description Ariya Hidayat 2010-08-08 12:09:52 PDT 
Inconsistent Qt version checks
Comment 1 Ariya Hidayat 2010-08-08 12:12:14 PDT 
Some are using the encoded hex, some others are using QT_VERSION_CHECK macro.

Will upload a patch.
Comment 2 Ariya Hidayat 2010-08-08 12:16:07 PDT 
Created attachment 63848 [details]
Patch
Comment 3 Antonio Gomes 2010-08-08 19:23:16 PDT 
Comment on attachment 63848 [details]
Patch

r=me
Comment 4 Ariya Hidayat 2010-08-08 22:50:00 PDT 
Manually committed r64965: http://trac.webkit.org/changeset/64965