Bug 43695

Summary: [Qt] Inconsistent Qt version checks
Product: WebKit Reporter: Ariya Hidayat <ariya.hidayat>
Component: New BugsAssignee: Ariya Hidayat <ariya.hidayat>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Qt
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch tonikitoo: review+

Ariya Hidayat
Reported 2010-08-08 12:09:52 PDT
Inconsistent Qt version checks
Attachments
Patch (14.04 KB, patch)
2010-08-08 12:16 PDT, Ariya Hidayat 		tonikitoo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ariya Hidayat
Comment 1 2010-08-08 12:12:14 PDT
Some are using the encoded hex, some others are using QT_VERSION_CHECK macro. Will upload a patch.
Ariya Hidayat
Comment 2 2010-08-08 12:16:07 PDT
Created attachment 63848 [details] Patch
Antonio Gomes
Comment 3 2010-08-08 19:23:16 PDT
Comment on attachment 63848 [details] Patch r=me
Ariya Hidayat
Comment 4 2010-08-08 22:50:00 PDT
Manually committed r64965: http://trac.webkit.org/changeset/64965
Note You need to log in before you can comment on or make changes to this bug.