Bug 43684

Summary: Add additional loader client functions need to complete WebKitTestRunner
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch andersca: review+

Description Sam Weinig 2010-08-07 16:07:27 PDT 
We need a few more callbacks.
Comment 1 Sam Weinig 2010-08-07 16:09:11 PDT 
Created attachment 63834 [details]
Patch
Comment 2 WebKit Review Bot 2010-08-07 16:10:39 PDT 
Attachment 63834 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:80:  Extra space between WKBundlePageDidCancelClientRedirectForFrameCallback and didCancelClientRedirectForFrame  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:81:  Extra space between WKBundlePageWillPerformClientRedirectForFrameCallback and willPerformClientRedirectForFrame  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:82:  Extra space between WKBundlePageDidChangeLocationWithinPageForFrameCallback and didChangeLocationWithinPageForFrame  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:83:  Extra space between WKBundlePageDidFinishDocumentLoadForFrameCallback and didFinishDocumentLoadForFrame  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:84:  Extra space between WKBundlePageDidHandleOnloadEventsForFrameCallback and didHandleOnloadEventsForFrame  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:85:  Extra space between WKBundlePageDidDisplayInsecureContentForFrameCallback and didDisplayInsecureContentForFrame  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:86:  Extra space between WKBundlePageDidRunInsecureContentForFrameCallback and didRunInsecureContentForFrame  [whitespace/declaration] [3]
Total errors found: 7 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2010-08-07 16:26:31 PDT 
Landed in r64927.