Bug 43674

Summary: Create a separate SimpleFontData constructor for SVG fonts and move the CTFontRef member to platform data
Product: WebKit Reporter: mitz
Component: TextAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric, webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Create a separate SimpleFontData constructor for SVG fonts and move the CTFontRef member to platform dat andersca: review+

Description mitz 2010-08-07 11:53:12 PDT
Patch forthcoming.
Comment 1 mitz 2010-08-07 11:54:03 PDT
Created attachment 63823 [details]
Create a separate SimpleFontData constructor for SVG fonts and move the CTFontRef member to platform dat
Comment 3 WebKit Review Bot 2010-08-07 12:07:08 PDT
http://trac.webkit.org/changeset/64915 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, and Qt Linux ARMv7 Release
Comment 4 Early Warning System Bot 2010-08-07 12:11:37 PDT
Attachment 63823 [details] did not build on qt:
Build output: http://queues.webkit.org/results/3674039
Comment 5 Dimitri Glazkov (Google) 2010-08-08 07:59:45 PDT
This broke Chromium Mac: http://build.webkit.org/builders/Chromium%20Mac%20Release/builds/11836/steps/compile-webkit/logs/stdio

Haven't yet looked at the details, just noticed.
Comment 6 mitz 2010-08-08 09:42:18 PDT
(In reply to comment #5)
> This broke Chromium Mac: http://build.webkit.org/builders/Chromium%20Mac%20Release/builds/11836/steps/compile-webkit/logs/stdio
> 
> Haven't yet looked at the details, just noticed.

Thanks. I committed r64950 in an attempt to fix it.
Comment 7 Dimitri Glazkov (Google) 2010-08-08 10:48:28 PDT
(In reply to comment #6)
> (In reply to comment #5)
> > This broke Chromium Mac: http://build.webkit.org/builders/Chromium%20Mac%20Release/builds/11836/steps/compile-webkit/logs/stdio
> > 
> > Haven't yet looked at the details, just noticed.
> 
> Thanks. I committed r64950 in an attempt to fix it.

It worked, yay! Thanks mitz.