Summary: | WebKitTestRunner should be more aggressive about ensuring consistent state between tests | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, ap, darin | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Sam Weinig
2010-08-06 16:29:21 PDT
Created attachment 64181 [details]
Patch
Comment on attachment 64181 [details]
Patch
r-ing for now, there is something weird in here.
> + WKRetainPtr<WKURLRef> url(AdoptWK, createWKURL("about:blank"));
> + WKPageLoadURL(m_mainWebView->page(), url.get());
It seems that this can affect performance a lot. DRT doesn't do that, does it?
(In reply to comment #4) > > + WKRetainPtr<WKURLRef> url(AdoptWK, createWKURL("about:blank")); > > + WKPageLoadURL(m_mainWebView->page(), url.get()); > > It seems that this can affect performance a lot. DRT doesn't do that, does it? DRT does, [mainFrame loadHTMLString:@"<html></html>" baseURL:[NSURL URLWithString:@"about:blank"]]; [mainFrame stopLoading]; in runTest(). I am not sure how much that differs in performance, but since we don't have that mechanism yet, I thought this would do nicely. Created attachment 64188 [details]
Patch 2
|