Bug 43646

Summary: [CHROMIUM] Prefer the medium-quality (bilinear) image resampling for 2D canvas.
Product: WebKit Reporter: Stephen White <senorblanco>
Component: New BugsAssignee: Stephen White <senorblanco>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch levin: review+

Description Stephen White 2010-08-06 15:00:28 PDT
[CHROMIUM] Prefer the medium-quality (bilinear) image resampling for 2D canvas.
Comment 1 Stephen White 2010-08-06 15:10:27 PDT
Created attachment 63765 [details]
Patch
Comment 2 Sam Weinig 2010-08-06 22:40:50 PDT
Is there a way to do this without throwing an #ifdef in the middle of that file?  Is this something other ports should consider?
Comment 3 Stephen White 2010-08-07 04:52:23 PDT
(In reply to comment #2)
> Is there a way to do this without throwing an #ifdef in the middle of that file?  Is this something other ports should consider?

Another way it could be done would be to define a "CanvasImageInterpolationQuality" in graphics.h, which could be #defined'ed by each platform.  Then at least the platform #if would be in platform/graphics, rather than here at this level.

Whether other ports want to do it is really up to their maintainers -- the canvas spec does not specify any particular algorithm for image resampling.
Comment 4 Stephen White 2010-08-09 11:02:59 PDT
Created attachment 63909 [details]
Patch
Comment 5 Stephen White 2010-08-09 11:03:51 PDT
(In reply to comment #4)
> Created an attachment (id=63909) [details]
> Patch

Here's a version with the platform-specific stuff pushed into GraphicsContext.h.
Comment 6 Stephen White 2010-08-10 15:02:54 PDT
Committed r65097: <http://trac.webkit.org/changeset/65097>
Comment 7 WebKit Review Bot 2010-08-10 17:02:19 PDT
http://trac.webkit.org/changeset/65097 might have broken GTK Linux 32-bit Release