Bug 43644

Summary:

[chromium] GraphicsContext3D should bypass the software rendering path when doing accelerated compositing

Product:

WebKit

Reporter:

Vangelis Kokkevis <vangelis>

Component:

WebKit Misc.

Assignee:

Vangelis Kokkevis <vangelis>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Proposed patch	none

Vangelis Kokkevis

Reported 2010-08-06 14:29:05 PDT

As the code currently stands, during gpu compositing, the graphics layer corresponding to a WebGL context can be asked to render its contents into a canvas backed GraphicsContext, resulting in an expensive GL readback operation that's not necessary. In the chromium code this happens when calling GraphicsContext3D::beginPaint() which was implemented for the software compositing path.

Attachments
Proposed patch (2.76 KB, patch) 2010-08-06 15:14 PDT, Vangelis Kokkevis	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Vangelis Kokkevis

Comment 1 2010-08-06 15:14:25 PDT

Created attachment 63767 [details] Proposed patch

Dimitri Glazkov (Google)

Comment 2 2010-08-09 10:15:02 PDT

Comment on attachment 63767 [details] Proposed patch ok.

Eric Seidel (no email)

Comment 3 2010-08-09 10:39:58 PDT

Comment on attachment 63767 [details] Proposed patch Clearing flags on attachment: 63767 Committed r64990: <http://trac.webkit.org/changeset/64990>

Eric Seidel (no email)

Comment 4 2010-08-09 10:40:03 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.