Bug 43633

Summary: Factor an AsyncScriptRunner out of Document
Product: WebKit Reporter: Tony Gentilcore <tonyg>
Component: New BugsAssignee: Tony Gentilcore <tonyg>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 20710    
Attachments:
Description Flags
Patch eric: review+, eric: commit-queue+

Tony Gentilcore
Reported 2010-08-06 11:58:21 PDT
Factor an AsyncScriptRunner out of Document
Attachments
Patch (21.03 KB, patch)
2010-08-06 12:05 PDT, Tony Gentilcore 		eric: review+
eric: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Gentilcore
Comment 1 2010-08-06 12:05:14 PDT
Created attachment 63749 [details] Patch
WebKit Review Bot
Comment 2 2010-08-06 12:06:45 PDT
Attachment 63749 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/dom/Document.h:51: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Seidel (no email)
Comment 3 2010-08-06 12:08:46 PDT
Comment on attachment 63749 [details] Patch LGTM.
Tony Gentilcore
Comment 4 2010-08-06 12:09:11 PDT
> WebCore/dom/Document.h:51: Code inside a namespace should not be indented. [whitespace/indent] [4] This is unavoidable. I added a forward decl in Document.h which is already indented.
Adam Barth
Comment 5 2010-08-06 14:35:45 PDT
> This is unavoidable. I added a forward decl in Document.h which is already indented. At some point we should bit the bullet and reformat this header.
Tony Gentilcore
Comment 6 2010-08-06 14:38:32 PDT
> At some point we should bit the bullet and reformat this header. After this lands I'll put together a patch to fix all the style violations in Document.h.
Tony Gentilcore
Comment 7 2010-08-06 15:10:51 PDT
Committed r64873: <http://trac.webkit.org/changeset/64873>
Note You need to log in before you can comment on or make changes to this bug.