Bug 43631

Summary:

add "const" to WebChromeClient::webView().

Product:

WebKit

Reporter:

Yongjun Zhang <yongjun_zhang>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

joepeck, yongjun_zhang

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.6

Attachments:

Description	Flags
Change WebChromeClient::webView() to be const.	eric: review+, eric: commit-queue+

Yongjun Zhang

Reported 2010-08-06 11:19:21 PDT

ChromeClient::didReceiveViewportArguments() has changed to be a "const" method. If we call WebChromeClient::webView() inside port-specific didReceiveViewportArguments() const, the compiler won't be happy because currently webView() is not const. We need to change WebChromeClient()::webView() to be "const".

Attachments
Change WebChromeClient::webView() to be const. (1.33 KB, patch) 2010-08-06 11:28 PDT, Yongjun Zhang	eric: review+ eric: commit-queue+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yongjun Zhang

Comment 1 2010-08-06 11:20:04 PDT

It is blocking <rdar://problem/8274174>.

Yongjun Zhang

Comment 2 2010-08-06 11:28:10 PDT

Created attachment 63744 [details] Change WebChromeClient::webView() to be const.

Eric Seidel (no email)

Comment 3 2010-08-06 13:15:44 PDT

Comment on attachment 63744 [details] Change WebChromeClient::webView() to be const. OK.

Joseph Pecoraro

Comment 4 2010-08-06 14:23:38 PDT

Committed r64868 M WebKit/mac/WebCoreSupport/WebChromeClient.h M WebKit/mac/ChangeLog r64868 = aa39e0ac7d3f2dd39f182bef3818b79e35d8db2e (refs/remotes/trunk) http://trac.webkit.org/changeset/64868

Note You need to log in before you can comment on or make changes to this bug.