Bug 43620

Summary: NPAPI headers should be included through npruntime_internal.h
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, abecsi, andersca, eric, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch none

Balazs Kelemen
Reported 2010-08-06 07:11:20 PDT
npruntime_internal.h says "If you need to include npapi.h or npruntime.h when building on X11, include this file instead of the actual npapi.h or npruntime.h." Currently in the WebKit2 directory there are files that includes npapi.h and npruntime.h directly. This brakes the build of the qt port. I would suggest to observe the rule everywhere.
Attachments
proposed patch (2.44 KB, patch)
2010-08-06 07:19 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2010-08-06 07:19:03 PDT
Created attachment 63720 [details] proposed patch Change includes in WebKit2
Eric Seidel (no email)
Comment 2 2010-08-06 14:44:39 PDT
Looks non-harmful.
Andras Becsi
Comment 3 2010-08-07 04:48:14 PDT
Committed r64905: <http://trac.webkit.org/changeset/64905>
WebKit Review Bot
Comment 4 2010-08-07 06:20:05 PDT
http://trac.webkit.org/changeset/64905 might have broken Leopard Intel Debug (Tests)
Balazs Kelemen
Comment 5 2010-08-07 06:51:03 PDT
Comment on attachment 63720 [details] proposed patch Clearing flags on committed patch.
Note You need to log in before you can comment on or make changes to this bug.