Bug 43593

Summary: WebView::backingStore should check if m_backingStoreBitmap is NULL
Product: WebKit Reporter: Jessie Berlin <jberlin>
Component: WebKit Misc.Assignee: Jessie Berlin <jberlin>
Status: RESOLVED FIXED    
Severity: Normal CC: jberlin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Add a null check to WebView::backingStore none

Description Jessie Berlin 2010-08-05 17:01:24 PDT 
There are cases when WebView::backingStore is called while m_backingStoreBitmap is NULL, such as after deleteBackingStore has been called in response to a WM_NCACTIVATE message (indicating a change in the the active/inactive state).

Instead of attempting to dereference a null pointer, we should return early with E_FAIL if m_backingStoreBitmap is NULL.
Comment 1 Jessie Berlin 2010-08-05 18:49:12 PDT 
Created attachment 63677 [details]
Add a null check to WebView::backingStore
Comment 2 Jon Honeycutt 2010-08-05 19:05:05 PDT 
Comment on attachment 63677 [details]
Add a null check to WebView::backingStore

r=me
Comment 3 Jessie Berlin 2010-08-05 19:19:33 PDT 
Comment on attachment 63677 [details]
Add a null check to WebView::backingStore

Committed in r64811
http://trac.webkit.org/changeset/64811