Bug 43585

Summary: Remove Invalid Asserts for Application Cache Quotas
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, joepeck
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch ddkilzer: review+

Description Joseph Pecoraro 2010-08-05 16:06:39 PDT 
These ASSERTs were added in:
<http://webkit.org/b/40627> Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)

They will always fail the first time with a client that uses a non-unlimited quota because:
  - ApplicationCacheStorage's singleton is initialized with noQuota defaults
  - WebApplicationCache uses the above singleton
  - When initializing the WebView _preferencesChanged will call setter, which runs this
     ASSERT before the default quota is being set for the first time!

  [WebApplicationCache setDefaultOriginQuota:[preferences applicationCacheDefaultOriginQuota]];
Comment 1 Joseph Pecoraro 2010-08-05 16:15:01 PDT 
Created attachment 63658 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2010-08-05 17:05:09 PDT 
Comment on attachment 63658 [details]
Patch

r=me
Comment 3 Joseph Pecoraro 2010-08-05 17:26:19 PDT 
Committed r64802
	M	WebKit/mac/ChangeLog
	M	WebKit/mac/WebView/WebPreferences.mm
r64802 = 71974a4e5fadb1b52f47ea1ab3fcfa7604e2dc86
http://trac.webkit.org/changeset/64802