Bug 43545

Summary: [Qt] Clean up the input method handling
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: PlatformAssignee: Simon Hausmann <hausmann>
Status: RESOLVED FIXED    
Severity: Normal CC: david.leong
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch vestbo: review+

Description Simon Hausmann 2010-08-05 02:29:36 PDT 
The code in EditorClientQt that sets the input method hints is inefficient.

When setting indiviual input method hints we end up calling QWidget::setInputMethodHints for every individual flag, which by itself results in a call to update() in the input method implementation.

A better solution would be to accumulate the input method hints and set them at once. This requires minor changes to the QWebPageClient interface.
Comment 1 Simon Hausmann 2010-08-05 05:09:46 PDT 
Created attachment 63578 [details]
Patch
Comment 2 Simon Hausmann 2010-08-05 05:40:36 PDT 
Committed r64737: <http://trac.webkit.org/changeset/64737>
Comment 3 Simon Hausmann 2010-08-05 05:43:51 PDT 
Revision r64737 cherry-picked into qtwebkit-2.1 with commit d22010b8f31d348848d25be618fa6f911dacf9da