Bug 43545

Summary: [Qt] Clean up the input method handling
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: PlatformAssignee: Simon Hausmann <hausmann>
Status: RESOLVED FIXED    
Severity: Normal CC: david.leong
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch vestbo: review+

Simon Hausmann
Reported 2010-08-05 02:29:36 PDT
The code in EditorClientQt that sets the input method hints is inefficient. When setting indiviual input method hints we end up calling QWidget::setInputMethodHints for every individual flag, which by itself results in a call to update() in the input method implementation. A better solution would be to accumulate the input method hints and set them at once. This requires minor changes to the QWebPageClient interface.
Attachments
Patch (7.60 KB, patch)
2010-08-05 05:09 PDT, Simon Hausmann 		vestbo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2010-08-05 05:09:46 PDT
Created attachment 63578 [details] Patch
Simon Hausmann
Comment 2 2010-08-05 05:40:36 PDT
Committed r64737: <http://trac.webkit.org/changeset/64737>
Simon Hausmann
Comment 3 2010-08-05 05:43:51 PDT
Revision r64737 cherry-picked into qtwebkit-2.1 with commit d22010b8f31d348848d25be618fa6f911dacf9da
Note You need to log in before you can comment on or make changes to this bug.