Bug 43545 - [Qt] Clean up the input method handling
Summary: [Qt] Clean up the input method handling
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Simon Hausmann
Keywords: Qt
Depends on:
Reported: 2010-08-05 02:29 PDT by Simon Hausmann
Modified: 2010-08-24 06:28 PDT (History)
1 user (show)

See Also:

Patch (7.60 KB, patch)
2010-08-05 05:09 PDT, Simon Hausmann
vestbo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hausmann 2010-08-05 02:29:36 PDT
The code in EditorClientQt that sets the input method hints is inefficient.

When setting indiviual input method hints we end up calling QWidget::setInputMethodHints for every individual flag, which by itself results in a call to update() in the input method implementation.

A better solution would be to accumulate the input method hints and set them at once. This requires minor changes to the QWebPageClient interface.
Comment 1 Simon Hausmann 2010-08-05 05:09:46 PDT
Created attachment 63578 [details]
Comment 2 Simon Hausmann 2010-08-05 05:40:36 PDT
Committed r64737: <http://trac.webkit.org/changeset/64737>
Comment 3 Simon Hausmann 2010-08-05 05:43:51 PDT
Revision r64737 cherry-picked into qtwebkit-2.1 with commit d22010b8f31d348848d25be618fa6f911dacf9da