Bug 43544 – [EFL]Implementation dispatchDecidePolicyForNavigationAction

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Ryuan Choi]

I want to call some other application when user click mailto.

I think that FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction is proper function.

[Ryuan Choi]

Created attachment 63565 [details]
Patch

[Ryuan Choi]

Created attachment 63573 [details]
Patch

[Ryuan Choi]

Created attachment 63681 [details]
Patch

[Ryuan Choi]

Created attachment 63694 [details]
proposed patch

Sorry I found wrong EAPI option in ewk_private.h. I removed

[Antonio Gomes]

Comment on attachment 63694 [details]
proposed patch

I think it looks good. I have one question:

> +
> +    PolicyAction policy;
> +    if (!ret)
> +        policy = PolicyIgnore;
> +    else {
> +        Frame* f = ewk_frame_core_get(m_frame);
> +        f->loader()->resetMultipleFormSubmissionProtection();
> +        policy = PolicyUse;
> +    }


You are unconditionally calling resetMultipleFormSubmissionProtection() . Should not you do so only with the NavicationAction involves that?

Se Qt's code below:

    if (!page->d->acceptNavigationRequest(m_webFrame, r, QWebPage::NavigationType(action.type()))) {
        if (action.type() == NavigationTypeFormSubmitted || action.type() == NavigationTypeFormResubmitted)
            m_frame->loader()->resetMultipleFormSubmissionProtection();

[Ryuan Choi]

(In reply to comment #5)
> (From update of attachment 63694 [details])
> I think it looks good. I have one question:
> 
> > +
> > +    PolicyAction policy;
> > +    if (!ret)
> > +        policy = PolicyIgnore;
> > +    else {
> > +        Frame* f = ewk_frame_core_get(m_frame);
> > +        f->loader()->resetMultipleFormSubmissionProtection();
> > +        policy = PolicyUse;
> > +    }
> 
> 
> You are unconditionally calling resetMultipleFormSubmissionProtection() . Should not you do so only with the NavicationAction involves that?
> 
> Se Qt's code below:
> 
>     if (!page->d->acceptNavigationRequest(m_webFrame, r, QWebPage::NavigationType(action.type()))) {
>         if (action.type() == NavigationTypeFormSubmitted || action.type() == NavigationTypeFormResubmitted)
>             m_frame->loader()->resetMultipleFormSubmissionProtection();

Ok, I'll add action related code

[Ryuan Choi]

Created attachment 63859 [details]
Patch

[Antonio Gomes]

Comment on attachment 63859 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 63859 [details]
Patch

Clearing flags on attachment: 63859

Committed r65163: <http://trac.webkit.org/changeset/65163>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.