Bug 43534

Summary:

Remove superfluous non-negative checks in HitTestResult:padding{Width|Height}

Product:

WebKit

Reporter:

Antonio Gomes <tonikitoo>

Component:

Layout and Rendering

Assignee:

Antonio Gomes <tonikitoo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hausmann, hyatt, steveblock

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
(committed with r64705, r=daniel bates) patch v1	none

Antonio Gomes

Reported 2010-08-04 19:50:18 PDT

As pointed out by Steve Block in https://bugs.webkit.org/show_bug.cgi?id=40197#c54 , the non-negative checks present in both paddingWidth and paddingHeight methods of HitTestResults class are superflous, after we changed the rect based hit testing logic of invalid padding from IntSize(-1, -1) to IntSize(0, 0). I missed updating these two method while addressing last hyatt's reviews. Patch coming.

Attachments
(committed with r64705, r=daniel bates) patch v1 (2.97 KB, patch) 2010-08-04 19:55 PDT, Antonio Gomes	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Antonio Gomes

Comment 1 2010-08-04 19:55:25 PDT

Created attachment 63536 [details] (committed with r64705, r=daniel bates) patch v1

Daniel Bates

Comment 2 2010-08-04 20:14:04 PDT

Comment on attachment 63536 [details] (committed with r64705, r=daniel bates) patch v1 Looks sane to me. r=me.

Antonio Gomes

Comment 3 2010-08-04 20:29:33 PDT

Comment on attachment 63536 [details] (committed with r64705, r=daniel bates) patch v1 Clearing flags on attachment: 63536 Committed r64705: <http://trac.webkit.org/changeset/64705>

Simon Hausmann

Comment 4 2010-08-24 01:39:11 PDT

Revision r64705 cherry-picked into qtwebkit-2.1 with commit 40071b732cbe2fe02f738c04d01da6e35ba84bac

Note You need to log in before you can comment on or make changes to this bug.