Summary: | NetscapePluginModule::try/unload should be cross-platform | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
Component: | New Bugs | Assignee: | Adam Roben (:aroben) <aroben> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 43189, 43513 | ||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2010-08-04 11:39:24 PDT
Created attachment 63474 [details]
Patch
Attachment 63474 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/Platform/win/ModuleWin.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/Platform/qt/ModuleQt.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/Platform/Module.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 3 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 63474 [details]
Patch
On mac, Module::unload should always leak the bundle, it's not specific to plug-ins.
Looks great otherwise!
Committed r64663: <http://trac.webkit.org/changeset/64663> Committed r64664: <http://trac.webkit.org/changeset/64664> Committed r64666: <http://trac.webkit.org/changeset/64666> Committed r64667: <http://trac.webkit.org/changeset/64667> Committed r64668: <http://trac.webkit.org/changeset/64668> |