Bug 43497

Summary: NetscapePluginModule::try/unload should be cross-platform
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: New BugsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 43189, 43513    
Attachments:
Description Flags
Patch andersca: review+

Adam Roben (:aroben)
Reported 2010-08-04 11:39:24 PDT
NetscapePluginModule::try/unload should be cross-platform
Attachments
Patch (25.21 KB, patch)
2010-08-04 11:45 PDT, Adam Roben (:aroben) 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2010-08-04 11:45:40 PDT
Created attachment 63474 [details] Patch
WebKit Review Bot
Comment 2 2010-08-04 11:47:59 PDT
Attachment 63474 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/Platform/win/ModuleWin.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/Platform/qt/ModuleQt.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/Platform/Module.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 3 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2010-08-04 12:02:15 PDT
Comment on attachment 63474 [details] Patch On mac, Module::unload should always leak the bundle, it's not specific to plug-ins. Looks great otherwise!
Adam Roben (:aroben)
Comment 4 2010-08-04 12:10:27 PDT
Committed r64663: <http://trac.webkit.org/changeset/64663>
Adam Roben (:aroben)
Comment 5 2010-08-04 12:29:26 PDT
Committed r64664: <http://trac.webkit.org/changeset/64664>
Adam Roben (:aroben)
Comment 6 2010-08-04 12:37:36 PDT
Committed r64666: <http://trac.webkit.org/changeset/64666>
Adam Roben (:aroben)
Comment 7 2010-08-04 12:50:13 PDT
Committed r64667: <http://trac.webkit.org/changeset/64667>
Adam Roben (:aroben)
Comment 8 2010-08-04 12:58:19 PDT
Committed r64668: <http://trac.webkit.org/changeset/64668>
Note You need to log in before you can comment on or make changes to this bug.