Bug 43480

Summary:

[Chromium] DumpRenderTree lacks functionality for new Geolocation delayed permission tests

Product:

WebKit

Reporter:

Steve Block <steveblock>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

joth, pfeldman, steveblock

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

Other

Bug Depends on:

45313

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	steveblock: review+

Steve Block

Reported 2010-08-04 05:28:30 PDT

fast/dom/Geolocation/delayed-permission-allowed.html fast/dom/Geolocation/delayed-permission-denied.html See Bug 40002

Attachments
Patch (1.45 KB, patch) 2010-09-08 04:09 PDT, Jonathan Dixon	no flags	Details Formatted Diff Diff
Patch (2.01 KB, patch) 2010-09-08 04:17 PDT, Jonathan Dixon	steveblock: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Steve Block

Comment 1 2010-08-17 14:41:29 PDT

fast/dom/Geolocation/delayed-permission-denied-for-multiple-requests.html fast/dom/Geolocation/delayed-permission-allowed-for-multiple-requests.html See Bug 42811

Jonathan Dixon

Comment 2 2010-09-08 04:09:34 PDT

Created attachment 66873 [details] Patch

Jonathan Dixon

Comment 3 2010-09-08 04:17:58 PDT

Created attachment 66875 [details] Patch

Steve Block

Comment 4 2010-09-09 04:48:27 PDT

Comment on attachment 66875 [details] Patch I guess this was fixed Chromium-side? I think it would be useful to link to that fix, either from the bug or the ChangeLog.

Jonathan Dixon

Comment 5 2010-09-09 06:17:34 PDT

Actually, the DRT fixes are all in https://bugs.webkit.org/show_bug.cgi?id=45313 (Not yet landed, so added as dependency) The test shell version of the fixes were in http://codereview.chromium.org/3294007/show

Jonathan Dixon

Comment 6 2010-09-10 05:41:33 PDT

I'm now landing the fixes & the expections file cleanup all in bug 45313 so marking this one as a dup *** This bug has been marked as a duplicate of bug 45313 ***

Note You need to log in before you can comment on or make changes to this bug.