Bug 43480 - [Chromium] DumpRenderTree lacks functionality for new Geolocation delayed permission tests
Summary: [Chromium] DumpRenderTree lacks functionality for new Geolocation delayed per...
Status: RESOLVED DUPLICATE of bug 45313
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 45313
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-04 05:28 PDT by Steve Block
Modified: 2010-09-10 05:41 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.45 KB, patch)
2010-09-08 04:09 PDT, Jonathan Dixon
no flags Details | Formatted Diff | Diff
Patch (2.01 KB, patch)
2010-09-08 04:17 PDT, Jonathan Dixon
steveblock: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-08-04 05:28:30 PDT
fast/dom/Geolocation/delayed-permission-allowed.html
fast/dom/Geolocation/delayed-permission-denied.html

See Bug 40002
Comment 1 Steve Block 2010-08-17 14:41:29 PDT
fast/dom/Geolocation/delayed-permission-denied-for-multiple-requests.html
fast/dom/Geolocation/delayed-permission-allowed-for-multiple-requests.html

See Bug 42811
Comment 2 Jonathan Dixon 2010-09-08 04:09:34 PDT
Created attachment 66873 [details]
Patch
Comment 3 Jonathan Dixon 2010-09-08 04:17:58 PDT
Created attachment 66875 [details]
Patch
Comment 4 Steve Block 2010-09-09 04:48:27 PDT
Comment on attachment 66875 [details]
Patch

I guess this was fixed Chromium-side? I think it would be useful to link to that fix, either from the bug or the ChangeLog.
Comment 5 Jonathan Dixon 2010-09-09 06:17:34 PDT
Actually, the DRT fixes are all in https://bugs.webkit.org/show_bug.cgi?id=45313 (Not yet landed, so added as dependency)

The test shell version of the fixes were in http://codereview.chromium.org/3294007/show
Comment 6 Jonathan Dixon 2010-09-10 05:41:33 PDT
I'm now landing the fixes & the expections file cleanup all in bug 45313 so marking this one as a dup

*** This bug has been marked as a duplicate of bug 45313 ***