Summary: | DevTools: get rid of delayed command dispatching on front-end side. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | loislo, webkit.review.bot, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Pavel Feldman
2010-08-04 05:13:56 PDT
Created attachment 63442 [details]
[PATCH] Proposed change.
Attachment 63442 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/DumpRenderTree/chromium/DRTDevToolsClient.cpp:67: Place brace on its own line for function definitions. [whitespace/braces] [4]
WebKitTools/DumpRenderTree/chromium/DRTDevToolsAgent.cpp:132: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 2 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 63442 [details]
[PATCH] Proposed change.
WebKit/chromium/src/js/Tests.js:1856
+ WebInspector.showElementsPanel = function()
Could you override another method that wouldn't depend on the fact that the elements panel should be shown? WebInspector.Panel.show may be a good candidate?
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/chromium/ChangeLog M WebKit/chromium/public/WebDevToolsAgent.h M WebKit/chromium/src/WebDevToolsAgentImpl.cpp M WebKit/chromium/src/WebDevToolsAgentImpl.h Committed r64646 Created attachment 63567 [details]
[PATCH] To land.
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/inspector/front-end/InspectorBackendStub.js M WebKit/chromium/ChangeLog M WebKit/chromium/public/WebDevToolsFrontendClient.h M WebKit/chromium/src/WebDevToolsAgentImpl.cpp M WebKit/chromium/src/WebDevToolsAgentImpl.h M WebKit/chromium/src/WebDevToolsFrontendImpl.cpp M WebKit/chromium/src/WebDevToolsFrontendImpl.h M WebKit/chromium/src/js/DevTools.js M WebKit/chromium/src/js/Tests.js M WebKitTools/ChangeLog M WebKitTools/DumpRenderTree/chromium/DRTDevToolsAgent.cpp M WebKitTools/DumpRenderTree/chromium/DRTDevToolsAgent.h M WebKitTools/DumpRenderTree/chromium/DRTDevToolsClient.cpp M WebKitTools/DumpRenderTree/chromium/DRTDevToolsClient.h Committed r64729 |