Summary: | Web Inspector: Remove "Online/Offline" icon for Chrome's appcache devtools UI. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kavita Kanetkar <kkanetkar> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bweinstein, commit-queue, joepeck, keishi, michaeln, pfeldman, pmuellr, rik, timothy, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Kavita Kanetkar
2010-08-03 17:05:45 PDT
What do you mean by "which is not correct." This Online/Offline indicator corresponds to the navigator.onLine value. It is the network connectivity of the machine. Is it not switching correctly, or is its value ambiguous (users might think it means "Using the Application Cache" or "Not Using the Application Cache"? Created attachment 63480 [details]
patch
From what I understand, we always returns true for navigator.onLine. I am disabling UI for chrome-only. It probably is confusing to end-users to see it always "Online". Please take a look at the patch.
Thanks!
Comment on attachment 63480 [details] patch (In reply to comment #2) > From what I understand, we always returns true for navigator.onLine. > I am disabling UI for chrome-only. It probably is confusing to end-users > to see it always "Online". Please take a look at the patch. Any idea why Chrome always returns true? Is there an open bug for this feature to be implemented? Can you create a bug or link me to it? Finally, can you file a follow up bug to re-enable the feature for Chrome pending the feature being implemented? Anyways, the patch looks good to me, just the open questions. Comment on attachment 63480 [details]
patch
Thanks for review. I think there's a chrome bug/discussion somewhere about this online-detection. Sure, I can file a follow-up bug to enable this once chrome has resolved the other issue.
File / link to the follow-up and I will cq+ (if you can't). Thanks! Comment on attachment 63480 [details] patch Rejecting patch 63480 from commit-queue. kkanetkar@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 63480 [details] patch Rejecting patch 63480 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Joseph Pecoraro', u'--force']" exit_code: 1 Parsed 5 diffs from patch file(s). patching file WebKit/chromium/src/js/DevTools.js Hunk #1 FAILED at 111. 1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/src/js/DevTools.js.rej patching file WebKit/chromium/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/inspector/front-end/Settings.js patching file WebCore/inspector/front-end/ApplicationCacheItemsView.js Full output: http://queues.webkit.org/results/3609768 @Kavita, did this get out of date? Does it need to be rebaselined? Created attachment 63631 [details] patch2 Conflicting changes from Bug 43479 landed before this. Resolved. Please take a look. Thanks. Comment on attachment 63631 [details]
patch2
Thanks for updating!
Comment on attachment 63631 [details] patch2 Clearing flags on attachment: 63631 Committed r64844: <http://trac.webkit.org/changeset/64844> All reviewed patches have been landed. Closing bug. |