Bug 43445

Summary: [GTK] Use correct path for Inspector data files in GTK+3.x builds
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
datainspector.diff none

Xan Lopez
Reported 2010-08-03 14:22:31 PDT
SSIA.
Attachments
datainspector.diff (2.31 KB, patch)
2010-08-03 14:24 PDT, Xan Lopez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2010-08-03 14:24:34 PDT
Created attachment 63376 [details] datainspector.diff
Martin Robinson
Comment 2 2010-08-03 15:02:59 PDT
This patch seems sane to me. Perhaps adding a WEBKITGTK_API_VERSION define and setting it to @WEBKITGTK_API_VERSION@ would make this bit of code future proof though. Then the path could just be: inspectorURI.set(g_filename_to_uri(DATA_DIR"/webkit-"WEBKITGTK_API_VERSION"/webinspector/inspector.html"
Xan Lopez
Comment 3 2010-08-03 15:27:37 PDT
Comment on attachment 63376 [details] datainspector.diff Martin is right, we should do as he says. I'll upload a patch doing that tomorrow.
Xan Lopez
Comment 4 2010-08-05 08:37:23 PDT
The patch suggested by Martin was committed as r64752, closing.
Note You need to log in before you can comment on or make changes to this bug.