Summary: | Accelerometer tests need V8 results | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, dino, eric, hans, jorlow, steveblock | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | 42865 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Dean Jackson
2010-08-03 13:42:46 PDT
Created attachment 63950 [details]
Patch
Comment on attachment 63950 [details]
Patch
r=me
Hans, can you please make a patch that sets the expected results for Chromium as well? (In reply to comment #3) > Hans, can you please make a patch that sets the expected results for Chromium as well? Will do once we enable it. Comment on attachment 63950 [details] Patch Rejecting patch 63950 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20806 test cases. fast/loader/recursive-before-unload-crash.html -> failed Exiting early after 1 failures. 14219 tests run. 252.83s total testing time 14218 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://queues.webkit.org/results/3730017 Comment on attachment 63950 [details]
Patch
Queue failure looks like flakiness. Trying again.
Comment on attachment 63950 [details] Patch Rejecting patch 63950 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20806 test cases. fast/loader/recursive-before-unload-crash.html -> failed Exiting early after 1 failures. 14219 tests run. 249.35s total testing time 14218 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://queues.webkit.org/results/3747017 Committed r65066: <http://trac.webkit.org/changeset/65066> Did it flake twice? or did this really cause a regression? Either way, we should get a bug on the flaky test so it can be fixed. > Did it flake twice?
Yes, it did. I couldn't reproduce the failure locally so I landed manually and it didn't seem to cause any failures in the continuous build.
Would you like me to file a bug against the test or against the commit queue?
In a perfect world, anytime we see a test flake (on the commit-queue or build.webkit.org) we should file a bug. Have filed Bug 43840 to track the test flakiness |