Bug 43443

Summary: Accelerometer tests need V8 results
Product: WebKit Reporter: Dean Jackson <dino>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, eric, hans, jorlow, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Bug Depends on: 42865    
Bug Blocks:    
Attachments:
Description Flags
Patch jorlow: review+, commit-queue: commit-queue-

Dean Jackson
Reported 2010-08-03 13:42:46 PDT
The new test fast/dom/Accelerometer/window-property.html does not pass with v8. It needs platform-specific results.
Attachments
Patch (3.19 KB, patch)
2010-08-09 16:30 PDT, Steve Block 		jorlow: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2010-08-09 16:30:56 PDT
Created attachment 63950 [details] Patch
Jeremy Orlow
Comment 2 2010-08-10 02:01:53 PDT
Comment on attachment 63950 [details] Patch r=me
Jeremy Orlow
Comment 3 2010-08-10 02:02:39 PDT
Hans, can you please make a patch that sets the expected results for Chromium as well?
Hans Wennborg
Comment 4 2010-08-10 02:29:00 PDT
(In reply to comment #3) > Hans, can you please make a patch that sets the expected results for Chromium as well? Will do once we enable it.
WebKit Commit Bot
Comment 5 2010-08-10 02:57:44 PDT
Comment on attachment 63950 [details] Patch Rejecting patch 63950 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20806 test cases. fast/loader/recursive-before-unload-crash.html -> failed Exiting early after 1 failures. 14219 tests run. 252.83s total testing time 14218 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://queues.webkit.org/results/3730017
Steve Block
Comment 6 2010-08-10 03:13:31 PDT
Comment on attachment 63950 [details] Patch Queue failure looks like flakiness. Trying again.
WebKit Commit Bot
Comment 7 2010-08-10 03:37:36 PDT
Comment on attachment 63950 [details] Patch Rejecting patch 63950 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20806 test cases. fast/loader/recursive-before-unload-crash.html -> failed Exiting early after 1 failures. 14219 tests run. 249.35s total testing time 14218 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://queues.webkit.org/results/3747017
Steve Block
Comment 8 2010-08-10 04:22:01 PDT
Committed r65066: <http://trac.webkit.org/changeset/65066>
Eric Seidel (no email)
Comment 9 2010-08-10 10:01:15 PDT
Did it flake twice? or did this really cause a regression? Either way, we should get a bug on the flaky test so it can be fixed.
Steve Block
Comment 10 2010-08-10 12:50:32 PDT
> Did it flake twice? Yes, it did. I couldn't reproduce the failure locally so I landed manually and it didn't seem to cause any failures in the continuous build. Would you like me to file a bug against the test or against the commit queue?
Eric Seidel (no email)
Comment 11 2010-08-10 14:42:15 PDT
In a perfect world, anytime we see a test flake (on the commit-queue or build.webkit.org) we should file a bug.
Steve Block
Comment 12 2010-08-11 02:05:48 PDT
Have filed Bug 43840 to track the test flakiness
Note You need to log in before you can comment on or make changes to this bug.