Bug 43432

Summary:

MathML merror element style adjustments

Product:

WebKit

Reporter:

François Sausset <sausset>

Component:

MathML

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac (Intel)

OS:

OS X 10.6

Attachments:

Description	Flags
Patch	none
Test case	none

Description François Sausset 2010-08-03 09:55:31 PDT

The default style of merror should make it easily detectable when reading a MathML rendering.
A patch that makes merror more clearly detectable and that roughly matches Mozilla behaviour will follow to have a consistent behaviour between different MathML implementations as the MathML3 specification let some freedom about merror style:
http://www.w3.org/TR/MathML3/chapter3.html#presm.merror

Comment 1 François Sausset 2010-08-03 09:57:49 PDT

Created attachment 63344 [details]
Patch

Comment 2 Darin Adler 2010-08-03 12:34:26 PDT

Comment on attachment 63344 [details]
Patch

Can we add a test case for this? We should be able to see this with getComputedStyle, so it could be tested with a dumpAsText-style test.

Comment 3 François Sausset 2010-08-03 13:07:01 PDT

Created attachment 63370 [details]
Test case

Test case adapted from the MathML 3 test suite example.

I don't understand what do you mean by "dumpAsText-style test". I'm quite new to WebKit development and I don't know all the subtleties.
Should I include the test in LayoutTests by submitting a new patch with expected results? Or do you suggest something else?

Comment 4 WebKit Commit Bot 2010-08-05 01:46:08 PDT

Comment on attachment 63344 [details]
Patch

Clearing flags on attachment: 63344

Committed r64723: <http://trac.webkit.org/changeset/64723>

Comment 5 WebKit Commit Bot 2010-08-05 01:46:13 PDT

All reviewed patches have been landed.  Closing bug.