Bug 43432

Summary: MathML merror element style adjustments
Product: WebKit Reporter: François Sausset <sausset>
Component: MathMLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.6   
Attachments:
Description Flags
Patch
none
Test case none

François Sausset
Reported 2010-08-03 09:55:31 PDT
The default style of merror should make it easily detectable when reading a MathML rendering. A patch that makes merror more clearly detectable and that roughly matches Mozilla behaviour will follow to have a consistent behaviour between different MathML implementations as the MathML3 specification let some freedom about merror style: http://www.w3.org/TR/MathML3/chapter3.html#presm.merror
Attachments
Patch (973 bytes, patch)
2010-08-03 09:57 PDT, François Sausset 		no flags
DetailsFormatted DiffDiff
Test case (371 bytes, application/xhtml+xml)
2010-08-03 13:07 PDT, François Sausset 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
François Sausset
Comment 1 2010-08-03 09:57:49 PDT
Created attachment 63344 [details] Patch
Darin Adler
Comment 2 2010-08-03 12:34:26 PDT
Comment on attachment 63344 [details] Patch Can we add a test case for this? We should be able to see this with getComputedStyle, so it could be tested with a dumpAsText-style test.
François Sausset
Comment 3 2010-08-03 13:07:01 PDT
Created attachment 63370 [details] Test case Test case adapted from the MathML 3 test suite example. I don't understand what do you mean by "dumpAsText-style test". I'm quite new to WebKit development and I don't know all the subtleties. Should I include the test in LayoutTests by submitting a new patch with expected results? Or do you suggest something else?
WebKit Commit Bot
Comment 4 2010-08-05 01:46:08 PDT
Comment on attachment 63344 [details] Patch Clearing flags on attachment: 63344 Committed r64723: <http://trac.webkit.org/changeset/64723>
WebKit Commit Bot
Comment 5 2010-08-05 01:46:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.