Summary: | [GTK] Does not paint the node highlight used by the inspector | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gustavo Noronha (kov) <gustavo> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | Keywords: | Gtk | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Gustavo Noronha (kov)
2010-08-03 09:37:41 PDT
Created attachment 63341 [details]
proposed patch
Comment on attachment 63341 [details] proposed patch >-void InspectorClient::highlight(Node* node) >+void InspectorClient::highlight(Node*) > { >- notImplemented(); >+ hideHighlight(); > } > > void InspectorClient::hideHighlight() > { >- notImplemented(); >+ // FIXME: we should be able to only invalidate the actual rects of >+ // the new and old nodes. We need to track the nodes, and take the >+ // actual highlight size into account when calculating the damage >+ // rect. >+ gtk_widget_queue_draw(GTK_WIDGET(m_inspectedWebView)); > } There's some huge epic fail in naming going on here ;) >+ ctx.save(); >+ ctx.clip(static_cast<IntRect>(event->area)); >+ frame->page()->inspectorController()->drawNodeHighlight(ctx); >+ ctx.restore(); > } As discussed on jabber, the save/restore stuff is probably not needed. > > return FALSE; >-- >1.7.1 > Comment on attachment 63341 [details] proposed patch Landed as r64567. |