| Summary: | re-enable WebGL on Leopard for now | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zhenyao Mo <zmo> | ||||
| Component: | WebGL | Assignee: | Zhenyao Mo <zmo> | ||||
| Status: | RESOLVED INVALID | ||||||
| Severity: | Normal | CC: | cmarrin, dglazkov, kbr, oliver, sam | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | 42118 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Zhenyao Mo
2010-08-02 14:25:50 PDT
Created attachment 63262 [details] patch This patch reverses the changes made in http://trac.webkit.org/changeset/63688. Let's do this for now until Chris Marrin's more complicated logic is in. This issue is making it difficult for Mo to develop, and since he's been doing a great deal of WebGL work and bug fixing recently I would like to address it now. The patch looks okay to me. CC'ing Sam Weinig in case checking this in is going to break one of the bots right now (I believe that test cases failing while bringing up a new bot was the motivation behind https://bugs.webkit.org/show_bug.cgi?id=42118 ). A quick targeted patch for that issue would be to disable WebGL at run time if the graphics card on Mac OS X is a GeForce 7300 (or 7000 series more generally). Comment on attachment 63262 [details] patch From cmarrin:"I need to complete the implementation for https://bugs.webkit.org/show_bug.cgi?id=42118 or this will break the build bots." OK, I am upgrading my machine to Snow Leopard. Good luck to others who's still using Leopard! |