Bug 43352

Summary: Initiate speech input requests on click event
Product: WebKit Reporter: Satish Sampath <satish>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 39485    
Attachments:
Description Flags
Patch none

Satish Sampath
Reported 2010-08-02 08:35:01 PDT
Instead of initiating speech input requests on mouseup, do it on click event similar to how some other elements do (for e.g. spin button). This introduces no change in functionality from a user perspective while allowing clean automation for test purposes.
Attachments
Patch (1.98 KB, patch)
2010-08-02 08:41 PDT, Satish Sampath 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Satish Sampath
Comment 1 2010-08-02 08:41:37 PDT
Created attachment 63221 [details] Patch
Kent Tamura
Comment 2 2010-08-02 16:48:23 PDT
Comment on attachment 63221 [details] Patch ok
Kent Tamura
Comment 3 2010-08-03 03:10:17 PDT
Comment on attachment 63221 [details] Patch I'll commit this.
Kent Tamura
Comment 4 2010-08-03 03:12:47 PDT
Comment on attachment 63221 [details] Patch Clearing flags on attachment: 63221 Committed r64542: <http://trac.webkit.org/changeset/64542>
Kent Tamura
Comment 5 2010-08-03 03:12:55 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2010-08-03 04:52:12 PDT
http://trac.webkit.org/changeset/64542 might have broken GTK Linux 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/64541 http://trac.webkit.org/changeset/64542 http://trac.webkit.org/changeset/64543
Note You need to log in before you can comment on or make changes to this bug.