Bug 43350

Summary:	warning: integer overflow in expression - JITPropertyAccess32_64.cpp
Product:	WebKit	Reporter:	Csaba Osztrogonác <ossy>
Component:	JavaScriptCore	Assignee:	Michael Saboff <msaboff>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	barraclough, loki, msaboff
Priority:	P2
Version:	528+ (Nightly build)
Hardware:	All
OS:	All
Bug Depends on:
Bug Blocks:	43191

Description Csaba Osztrogonác 2010-08-02 08:16:45 PDT

http://trac.webkit.org/changeset/64320 caused the following warnings on the Qt Linux bot:

../../../JavaScriptCore/jit/JITPropertyAccess32_64.cpp: In member function ‘void JSC::JIT::emit_op_put_by_val(JSC::Instruction*)’:
../../../JavaScriptCore/jit/JITPropertyAccess32_64.cpp:378: warning: integer overflow in expression
../../../JavaScriptCore/jit/JITPropertyAccess32_64.cpp:379: warning: integer overflow in expression
../../../JavaScriptCore/jit/JITPropertyAccess32_64.cpp:382: warning: integer overflow in expression
../../../JavaScriptCore/jit/JITPropertyAccess32_64.cpp: In member function ‘void JSC::JIT::privateCompilePatchGetArrayLength(JSC::ReturnAddressPtr)’:
../../../JavaScriptCore/jit/JITPropertyAccess32_64.cpp:735: warning: integer overflow in expression

We should fix it to treat warnings as errors by default.

Comment 1 Gabor Loki 2010-08-10 08:09:28 PDT

Fixed (probably in r64937).