| Summary: | Speculative revert of 64425 due to Chromium instability | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jeremy Orlow <jorlow> | ||||||
| Component: | New Bugs | Assignee: | Jeremy Orlow <jorlow> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | kenneth, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 42592 | ||||||||
| Attachments: |
|
||||||||
|
Description
Jeremy Orlow
2010-08-02 07:26:37 PDT
Created attachment 63217 [details]
Patch
Created attachment 63218 [details]
Patch
Attachment 63217 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/PopupMenu.h:53: Alphabetical sorting problem. [build/include_order] [4]
WebCore/platform/wx/PopupMenuWx.cpp:81: Use 0 instead of NULL. [readability/null] [5]
WebCore/platform/wx/PopupMenuWx.cpp:83: Use 0 instead of NULL. [readability/null] [5]
Total errors found: 3 in 41 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 63218 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/PopupMenu.h:53: Alphabetical sorting problem. [build/include_order] [4]
WebCore/platform/wx/PopupMenuWx.cpp:81: Use 0 instead of NULL. [readability/null] [5]
WebCore/platform/wx/PopupMenuWx.cpp:83: Use 0 instead of NULL. [readability/null] [5]
Total errors found: 3 in 41 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r64462: <http://trac.webkit.org/changeset/64462> So did it fix it? Looks like yes. :-( I commented in the original bug. Comment on attachment 63218 [details]
Patch
removing the patch from the review queue
|