RESOLVED FIXED 43347
Speculative revert of 64425 due to Chromium instability 
https://bugs.webkit.org/show_bug.cgi?id=43347
Summary Speculative revert of 64425 due to Chromium instability
Jeremy Orlow
Reported 2010-08-02 07:26:37 PDT
Speculative revert of 64425 due to Chromium instability
Attachments
Patch (164.43 KB, patch)
2010-08-02 07:44 PDT, Jeremy Orlow 		no flags
DetailsFormatted DiffDiff
Patch (164.09 KB, patch)
2010-08-02 07:47 PDT, Jeremy Orlow 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2010-08-02 07:44:09 PDT
Created attachment 63217 [details] Patch
Jeremy Orlow
Comment 2 2010-08-02 07:47:06 PDT
Created attachment 63218 [details] Patch
WebKit Review Bot
Comment 3 2010-08-02 07:51:30 PDT
Attachment 63217 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/PopupMenu.h:53: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/wx/PopupMenuWx.cpp:81: Use 0 instead of NULL. [readability/null] [5] WebCore/platform/wx/PopupMenuWx.cpp:83: Use 0 instead of NULL. [readability/null] [5] Total errors found: 3 in 41 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 4 2010-08-02 07:53:39 PDT
Attachment 63218 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/PopupMenu.h:53: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/wx/PopupMenuWx.cpp:81: Use 0 instead of NULL. [readability/null] [5] WebCore/platform/wx/PopupMenuWx.cpp:83: Use 0 instead of NULL. [readability/null] [5] Total errors found: 3 in 41 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jeremy Orlow
Comment 5 2010-08-02 07:54:08 PDT
Committed r64462: <http://trac.webkit.org/changeset/64462>
Kenneth Rohde Christiansen
Comment 6 2010-08-02 10:46:34 PDT
So did it fix it?
Jeremy Orlow
Comment 7 2010-08-02 13:05:10 PDT
Looks like yes. :-( I commented in the original bug.
Tony Chang
Comment 8 2010-08-02 18:18:15 PDT
Comment on attachment 63218 [details] Patch removing the patch from the review queue
Note You need to log in before you can comment on or make changes to this bug.