Bug 43347 - Speculative revert of 64425 due to Chromium instability
Summary: Speculative revert of 64425 due to Chromium instability
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Jeremy Orlow
URL:
Keywords:
Depends on:
Blocks: 42592
  Show dependency tree / graph
 
Reported: 2010-08-02 07:26 PDT by Jeremy Orlow
Modified: 2010-08-02 18:18 PDT (History)
2 users (show)

See Also:

Attachments
Patch (164.43 KB, patch)
2010-08-02 07:44 PDT, Jeremy Orlow 		no flags Details | Formatted Diff | Diff
Patch (164.09 KB, patch)
2010-08-02 07:47 PDT, Jeremy Orlow 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2010-08-02 07:26:37 PDT 
Speculative revert of 64425 due to Chromium instability
Comment 1 Jeremy Orlow 2010-08-02 07:44:09 PDT 
Created attachment 63217 [details]
Patch
Comment 2 Jeremy Orlow 2010-08-02 07:47:06 PDT 
Created attachment 63218 [details]
Patch
Comment 3 WebKit Review Bot 2010-08-02 07:51:30 PDT 
Attachment 63217 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/PopupMenu.h:53:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/platform/wx/PopupMenuWx.cpp:81:  Use 0 instead of NULL.  [readability/null] [5]
WebCore/platform/wx/PopupMenuWx.cpp:83:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 3 in 41 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Review Bot 2010-08-02 07:53:39 PDT 
Attachment 63218 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/PopupMenu.h:53:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/platform/wx/PopupMenuWx.cpp:81:  Use 0 instead of NULL.  [readability/null] [5]
WebCore/platform/wx/PopupMenuWx.cpp:83:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 3 in 41 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Jeremy Orlow 2010-08-02 07:54:08 PDT 
Committed r64462: <http://trac.webkit.org/changeset/64462>
Comment 6 Kenneth Rohde Christiansen 2010-08-02 10:46:34 PDT 
So did it fix it?
Comment 7 Jeremy Orlow 2010-08-02 13:05:10 PDT 
Looks like yes.  :-(

I commented in the original bug.
Comment 8 Tony Chang 2010-08-02 18:18:15 PDT 
Comment on attachment 63218 [details]
Patch

removing the patch from the review queue