Bug 43322

Summary: [EFL] REGRESSION(64425) need to fix build break
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: antognolli+webkit, leandro, lucas.de.marchi, paroga
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Ryuan Choi
Reported 2010-08-01 17:55:24 PDT
I got an error like below /workspace/WebKit/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:52:26: fatal error: PopupMenuEfl.h: No such file or directory compilation terminated. make[2]: *** [WebKit/CMakeFiles/ewebkit.dir/efl/WebCoreSupport/ChromeClientEfl.cpp.o] 오류 1 make[2]: *** 끝나지 않은 작업을 기다리고 있습니다.... make[1]: *** [WebKit/CMakeFiles/ewebkit.dir/all] 오류 2 make: *** [all] 오류 2
Attachments
Patch (1.09 KB, patch)
2010-08-01 18:01 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (1.08 KB, patch)
2010-08-01 21:25 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (1.03 KB, patch)
2010-08-01 21:37 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2010-08-01 18:01:52 PDT
Created attachment 63177 [details] Patch
Patrick R. Gansterer
Comment 2 2010-08-01 20:52:39 PDT
Please add it into the WebKit/efl/CMakeListsEfl.txt instead of the CMakeLists.txt. CMakeLists.txt is only for platform-independet stuff
Ryuan Choi
Comment 3 2010-08-01 21:19:53 PDT
(In reply to comment #2) > Please add it into the WebKit/efl/CMakeListsEfl.txt instead of the CMakeLists.txt. > CMakeLists.txt is only for platform-independet stuff Thank you for your advice. I'll create WebKit/CMakeListsEfl.txt
Ryuan Choi
Comment 4 2010-08-01 21:25:14 PDT
Created attachment 63179 [details] Patch
Ryuan Choi
Comment 5 2010-08-01 21:37:29 PDT
Created attachment 63180 [details] Patch
Leandro Pereira
Comment 6 2010-08-03 08:47:25 PDT
Comment on attachment 63180 [details] Patch Clearing flags on attachment: 63180 Committed r64559: <http://trac.webkit.org/changeset/64559>
Leandro Pereira
Comment 7 2010-08-03 08:47:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.