Summary: | Fix WebCore+SVG compile breakage from 4313 | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||||||
Component: | SVG | Assignee: | Eric Seidel (no email) <eric> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | ||||||||||||
Priority: | P4 | ||||||||||||
Version: | 420+ | ||||||||||||
Hardware: | Mac | ||||||||||||
OS: | OS X 10.4 | ||||||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2005-08-08 01:40:30 PDT
Created attachment 3276 [details]
This patch fixes most of the issues, but not all.... yet.
Created attachment 3277 [details]
Should be a complete fix.
I'm off to bed. I'll run all the layout tests in the morning and commit.
Created attachment 3281 [details]
Final patch.
Comment on attachment 3281 [details]
Final patch.
Fixes WebCore+SVG to build again. This patch shouldn't really need review,
since it's a build-fix, only affects kdom/ksvg2, and is doing the exact same
thing as darin's 4313. However you now know about it if you care to comment.
Unless anyone objects, I'll commit it later on.
Comment on attachment 3281 [details]
Final patch.
The call functions also have to be updated to use the new name, callAsFunction.
Created attachment 3283 [details]
Adding call -> callFunction() change per darin's suggestion.
Comment on attachment 3283 [details]
Adding call -> callFunction() change per darin's suggestion.
Again, I'll wait a bit to see if anyone has further comments, then will commit.
All test SVG layout tests pass.
Comment on attachment 3283 [details]
Adding call -> callFunction() change per darin's suggestion.
Looks fine -- best if there was a way to test this, tho; Eric says we can't
test because of the JavaScript slot change.
|