Bug 4332 - Fix WebCore+SVG compile breakage from 4313
Summary: Fix WebCore+SVG compile breakage from 4313
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-08 01:40 PDT by Eric Seidel (no email)
Modified: 2005-08-08 13:36 PDT (History)
0 users

See Also:


Attachments
This patch fixes most of the issues, but not all.... yet. (639.08 KB, patch)
2005-08-08 01:41 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Should be a complete fix. (640.07 KB, patch)
2005-08-08 02:22 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Final patch. (640.23 KB, patch)
2005-08-08 11:24 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Adding call -> callFunction() change per darin's suggestion. (641.33 KB, patch)
2005-08-08 13:12 PDT, Eric Seidel (no email)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2005-08-08 01:40:30 PDT
Now that http://bugzilla.opendarwin.org/show_bug.cgi?id=4313 is landed, kdom and friends are broken.

This needs to be fixed.
Comment 1 Eric Seidel (no email) 2005-08-08 01:41:28 PDT
Created attachment 3276 [details]
This patch fixes most of the issues, but not all.... yet.
Comment 2 Eric Seidel (no email) 2005-08-08 02:22:37 PDT
Created attachment 3277 [details]
Should be a complete fix.

I'm off to bed.  I'll run all the layout tests in the morning and commit.
Comment 3 Eric Seidel (no email) 2005-08-08 11:24:24 PDT
Created attachment 3281 [details]
Final patch.
Comment 4 Eric Seidel (no email) 2005-08-08 11:27:01 PDT
Comment on attachment 3281 [details]
Final patch.

Fixes WebCore+SVG to build again.  This patch shouldn't really need review,
since it's a build-fix, only affects kdom/ksvg2, and is doing the exact same
thing as darin's 4313.	However you now know about it if you care to comment. 
Unless anyone objects, I'll commit it later on.
Comment 5 Darin Adler 2005-08-08 11:38:53 PDT
Comment on attachment 3281 [details]
Final patch.

The call functions also have to be updated to use the new name, callAsFunction.
Comment 6 Eric Seidel (no email) 2005-08-08 13:12:09 PDT
Created attachment 3283 [details]
Adding call -> callFunction() change per darin's suggestion.
Comment 7 Eric Seidel (no email) 2005-08-08 13:13:17 PDT
Comment on attachment 3283 [details]
Adding call -> callFunction() change per darin's suggestion.

Again, I'll wait a bit to see if anyone has further comments, then will commit.
 All test SVG layout tests pass.
Comment 8 Darin Adler 2005-08-08 13:23:37 PDT
Comment on attachment 3283 [details]
Adding call -> callFunction() change per darin's suggestion.

Looks fine -- best if there was a way to test this, tho; Eric says we can't
test because of the JavaScript slot change.