Bug 43308 – Touching SVGNames should only rebuild hundreds of files, not thousands

• Component: New Bugs
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

Touching SVGNames should only rebuild hundreds of files, not thousands

[Eric Seidel (no email)]

Created attachment 63162 [details]
Patch

[WebKit Review Bot]

Attachment 63162 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/svg/SVGPathSeg.h:28:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Seidel (no email)]

Created attachment 63163 [details]
Now with ChangeLog

[Eric Seidel (no email)]

(In reply to comment #2)
> WebCore/svg/SVGPathSeg.h:28:  Code inside a namespace should not be indented.  [whitespace/indent] [4]

Get a life, StyleBot.

[Darin Adler]

Comment on attachment 63163 [details]
Now with ChangeLog

>  		895253DF116C4F0600CABF00 /* FileThreadTask.h in Headers */ = {isa = PBXBuildFile; fileRef = 895253DE116C4F0600CABF00 /* FileThreadTask.h */; };
> -		897A2D2211FF58A50082740C /* DOMFileSystem.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 897A2D1911FF58A50082740C /* DOMFileSystem.cpp */; };
> -		897A2D2311FF58A50082740C /* DOMFileSystem.h in Headers */ = {isa = PBXBuildFile; fileRef = 897A2D1A11FF58A50082740C /* DOMFileSystem.h */; };
> -		897A2D2511FF58A50082740C /* Entry.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 897A2D1C11FF58A50082740C /* Entry.cpp */; };
> -		897A2D2611FF58A50082740C /* Entry.h in Headers */ = {isa = PBXBuildFile; fileRef = 897A2D1D11FF58A50082740C /* Entry.h */; };
> -		897A2D2711FF58A50082740C /* EntryCallback.h in Headers */ = {isa = PBXBuildFile; fileRef = 897A2D1E11FF58A50082740C /* EntryCallback.h */; };
> -		897A2D2911FF58A50082740C /* ErrorCallback.h in Headers */ = {isa = PBXBuildFile; fileRef = 897A2D2011FF58A50082740C /* ErrorCallback.h */; };
> -		897A2D2A11FF58A50082740C /* FileSystemCallback.h in Headers */ = {isa = PBXBuildFile; fileRef = 897A2D2111FF58A50082740C /* FileSystemCallback.h */; };
> -		897A2D4F11FF6C900082740C /* JSEntry.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 897A2D4911FF6C900082740C /* JSEntry.cpp */; };
> -		897A2D5011FF6C900082740C /* JSEntry.h in Headers */ = {isa = PBXBuildFile; fileRef = 897A2D4A11FF6C900082740C /* JSEntry.h */; };
> -		897A2D5111FF6C900082740C /* JSEntryCallback.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 897A2D4B11FF6C900082740C /* JSEntryCallback.cpp */; };
> -		897A2D5211FF6C900082740C /* JSEntryCallback.h in Headers */ = {isa = PBXBuildFile; fileRef = 897A2D4C11FF6C900082740C /* JSEntryCallback.h */; };
> -		897A2D5311FF6C900082740C /* JSErrorCallback.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 897A2D4D11FF6C900082740C /* JSErrorCallback.cpp */; };
> -		897A2D5411FF6C900082740C /* JSErrorCallback.h in Headers */ = {isa = PBXBuildFile; fileRef = 897A2D4E11FF6C900082740C /* JSErrorCallback.h */; };
> -		897A2D5711FF6CA40082740C /* JSFileSystemCallback.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 897A2D5511FF6CA40082740C /* JSFileSystemCallback.cpp */; };
> -		897A2D5811FF6CA40082740C /* JSFileSystemCallback.h in Headers */ = {isa = PBXBuildFile; fileRef = 897A2D5611FF6CA40082740C /* JSFileSystemCallback.h */; };
> -		897A2D63120001220082740C /* Flags.h in Headers */ = {isa = PBXBuildFile; fileRef = 897A2D60120001220082740C /* Flags.h */; };
> -		897A2D77120001440082740C /* Metadata.h in Headers */ = {isa = PBXBuildFile; fileRef = 897A2D73120001440082740C /* Metadata.h */; };
> -		897A2D79120001440082740C /* MetadataCallback.h in Headers */ = {isa = PBXBuildFile; fileRef = 897A2D75120001440082740C /* MetadataCallback.h */; };
> -		897A2D8F1200035F0082740C /* JSDOMFileSystem.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 897A2D8D1200035F0082740C /* JSDOMFileSystem.cpp */; };
> -		897A2D901200035F0082740C /* JSDOMFileSystem.h in Headers */ = {isa = PBXBuildFile; fileRef = 897A2D8E1200035F0082740C /* JSDOMFileSystem.h */; };
> -		897A2D93120003760082740C /* JSFlags.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 897A2D91120003760082740C /* JSFlags.cpp */; };
> -		897A2D94120003760082740C /* JSFlags.h in Headers */ = {isa = PBXBuildFile; fileRef = 897A2D92120003760082740C /* JSFlags.h */; };
> -		897A2D99120003A00082740C /* JSMetadata.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 897A2D95120003A00082740C /* JSMetadata.cpp */; };
> -		897A2D9A120003A00082740C /* JSMetadata.h in Headers */ = {isa = PBXBuildFile; fileRef = 897A2D96120003A00082740C /* JSMetadata.h */; };
> -		897A2D9B120003A00082740C /* JSMetadataCallback.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 897A2D97120003A00082740C /* JSMetadataCallback.cpp */; };
> -		897A2D9C120003A00082740C /* JSMetadataCallback.h in Headers */ = {isa = PBXBuildFile; fileRef = 897A2D98120003A00082740C /* JSMetadataCallback.h */; };
>  		8988E10E11A3508B00DB732E /* BlobItem.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 8988E10C11A3508B00DB732E /* BlobItem.cpp */; };
>  		8988E10F11A3508B00DB732E /* BlobItem.h in Headers */ = {isa = PBXBuildFile; fileRef = 8988E10D11A3508B00DB732E /* BlobItem.h */; settings = {ATTRIBUTES = (Private, ); }; };

What is this change about?

[Eric Seidel (no email)]

(In reply to comment #5)
> (From update of attachment 63163 [details])
> >  		8988E10F11A3508B00DB732E /* BlobItem.h in Headers */ = {isa = PBXBuildFile; fileRef = 8988E10D11A3508B00DB732E /* BlobItem.h */; settings = {ATTRIBUTES = (Private, ); }; };
> 
> What is this change about?

Your guess is as good as mine.  XCode kept making it every time I would add SVGPathSeg.cpp.  My suspicion is its fallout from earlier project file corruption.  Not sure.

[Eric Seidel (no email)]

This is only really the tip of the iceberg.  The big win comes from fixing bug 42025.   (Fixing DECLARE_ANIMATED_PROPERTY).

[Eric Seidel (no email)]

(In reply to comment #6)
> (In reply to comment #5)
> > (From update of attachment 63163 [details] [details])
> > >  		8988E10F11A3508B00DB732E /* BlobItem.h in Headers */ = {isa = PBXBuildFile; fileRef = 8988E10D11A3508B00DB732E /* BlobItem.h */; settings = {ATTRIBUTES = (Private, ); }; };
> > 
> > What is this change about?
> 
> Your guess is as good as mine.  XCode kept making it every time I would add SVGPathSeg.cpp.  My suspicion is its fallout from earlier project file corruption.  Not sure.

I'm updating my checkout and going to try adding the .cpp file again to see if XCode does fewer crazy things this time.

[WebKit Review Bot]

Attachment 63163 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/svg/SVGPathSeg.h:28:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Nikolas Zimmermann]

Comment on attachment 63163 [details]
Now with ChangeLog

WebCore/ChangeLog:15
 +          I re-indented on header to stop check-webkit-style from complaining.
What did you reindent? I thought you wanted to reindent SVGPathSeg.h, which would be fine, and would stop style bot from complaining.
Please do that before you land, r=me.

[Eric Seidel (no email)]

Created attachment 63498 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 63498 [details]
Patch for landing

Clearing flags on attachment: 63498

Committed r64793: <http://trac.webkit.org/changeset/64793>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.