Bug 43288

Summary: Add an NPObject class template helper to TestNetscapePlugin
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch sam: review+

Anders Carlsson
Reported 2010-07-30 16:54:50 PDT
Add an NPObject class template helper to TestNetscapePlugin
Attachments
Patch (9.28 KB, patch)
2010-07-30 16:59 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (9.36 KB, patch)
2010-07-30 17:10 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-07-30 16:59:30 PDT
Created attachment 63127 [details] Patch
WebKit Review Bot
Comment 2 2010-07-30 17:00:47 PDT
Attachment 63127 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginTest.h:38: Extra space before ( in function call [whitespace/parens] [4] WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginTest.h:140: One space before end of line comments [whitespace/comments] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3 2010-07-30 17:05:47 PDT
Attachment 63127 [details] did not build on qt: Build output: http://queues.webkit.org/results/3618299
Anders Carlsson
Comment 4 2010-07-30 17:10:01 PDT
Created attachment 63128 [details] Patch
WebKit Review Bot
Comment 5 2010-07-30 17:13:40 PDT
Attachment 63128 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginTest.h:39: Extra space before ( in function call [whitespace/parens] [4] WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginTest.h:141: One space before end of line comments [whitespace/comments] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 6 2010-08-01 12:40:12 PDT
Committed r64443: <http://trac.webkit.org/changeset/64443>
Note You need to log in before you can comment on or make changes to this bug.