Bug 43278

Summary: [Gtk] Enable view mode media feature layout test
Product: WebKit Reporter: Luiz Agostini <luiz>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, kenneth, mrobinson, tonikitoo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Add API to support the feature, and the testing infrastructure to test it none

Luiz Agostini
Reported 2010-07-30 16:13:52 PDT
Test fast/media/view-mode-media-feature.html is skipped because LayoutTestController lacks method setViewModeMediaFeature().
Attachments
Add API to support the feature, and the testing infrastructure to test it (18.00 KB, patch)
2010-08-18 14:42 PDT, Gustavo Noronha (kov) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2010-08-18 14:42:43 PDT
Created attachment 64775 [details] Add API to support the feature, and the testing infrastructure to test it
WebKit Review Bot
Comment 2 2010-08-18 14:43:44 PDT
Attachment 64775 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit/gtk/webkit/webkitwebview.h:68: This { should be at the end of the previous line [whitespace/braces] [4] WebKit/gtk/webkit/webkitwebview.h:352: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/webkit/webkitwebview.h:356: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kenneth Rohde Christiansen
Comment 3 2010-08-18 14:44:54 PDT
Comment on attachment 64775 [details] Add API to support the feature, and the testing infrastructure to test it Looks good!
Gustavo Noronha (kov)
Comment 4 2010-08-18 14:51:45 PDT
Comment on attachment 64775 [details] Add API to support the feature, and the testing infrastructure to test it Thanks, Kenneth! I'll switch the review flag to ? just to get the EWS bots to try the patch for me since they seem to not build patches after they get r+ =(
Kenneth Rohde Christiansen
Comment 5 2010-08-18 14:52:41 PDT
Fine :-) history records the r+
Gustavo Noronha (kov)
Comment 6 2010-08-19 06:18:29 PDT
(In reply to comment #2) > Attachment 64775 [details] did not pass style-queue: > > Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 > WebKit/gtk/webkit/webkitwebview.h:68: This { should be at the end of the previous line [whitespace/braces] [4] > WebKit/gtk/webkit/webkitwebview.h:352: Extra space before ( in function call [whitespace/parens] [4] > WebKit/gtk/webkit/webkitwebview.h:356: Extra space before ( in function call [whitespace/parens] [4] > Total errors found: 3 in 12 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. FWIW, these are false positives. I thought out API headers were already special-cased, but it looks like they still need to be =)
Gustavo Noronha (kov)
Comment 7 2010-08-19 06:19:09 PDT
Comment on attachment 64775 [details] Add API to support the feature, and the testing infrastructure to test it Removing flag, I'll land this with kenne's r+ as soon as I finish my final build test here.
Gustavo Noronha (kov)
Comment 8 2010-08-19 06:32:50 PDT
Landed as r65666.
Gustavo Noronha (kov)
Comment 9 2010-08-19 06:33:33 PDT
(In reply to comment #8) > Landed as r65666. The 65th commit of the devil, or something.
Note You need to log in before you can comment on or make changes to this bug.