Bug 43268

Summary:

Implement NPN_Evaluate

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	sam: review+

Description Anders Carlsson 2010-07-30 13:35:06 PDT

Implement NPN_Evaluate

Comment 1 Anders Carlsson 2010-07-30 13:43:42 PDT

Created attachment 63098 [details]
Patch

Comment 2 Sam Weinig 2010-07-30 14:36:38 PDT

Comment on attachment 63098 [details]
Patch


> +    bool evaluate(NPObject*, const WebCore::String &scriptString, NPVariant* result);

& on the wrong side.

> +
>      void setStatusbarText(const WebCore::String&);
> +    bool evaluate(NPObject*, const WebCore::String &scriptString, NPVariant* result);

Here too.


> +    // Evaluates the given script string in the context of the given NPObject.
> +    virtual bool evaluate(NPObject*, const WebCore::String &scriptString, NPVariant* result, bool allowPopups) = 0;
> +

And here too.


>  
> +bool PluginView::evaluate(NPObject* npObject, const String &scriptString, NPVariant* result, bool allowPopups)
> +{

And again.

> +    virtual bool evaluate(NPObject*, const WebCore::String &scriptString, NPVariant* result, bool allowPopups);
Once more!

r=me

Comment 3 Anders Carlsson 2010-07-30 14:44:24 PDT

Committed r64377: <http://trac.webkit.org/changeset/64377>