Bug 43268

Summary:

Implement NPN_Evaluate

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	sam: review+

Anders Carlsson

Reported 2010-07-30 13:35:06 PDT

Implement NPN_Evaluate

Attachments
Patch (13.88 KB, patch) 2010-07-30 13:43 PDT, Anders Carlsson	sam: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2010-07-30 13:43:42 PDT

Created attachment 63098 [details] Patch

Sam Weinig

Comment 2 2010-07-30 14:36:38 PDT

Comment on attachment 63098 [details] Patch > + bool evaluate(NPObject*, const WebCore::String &scriptString, NPVariant* result); & on the wrong side. > + > void setStatusbarText(const WebCore::String&); > + bool evaluate(NPObject*, const WebCore::String &scriptString, NPVariant* result); Here too. > + // Evaluates the given script string in the context of the given NPObject. > + virtual bool evaluate(NPObject*, const WebCore::String &scriptString, NPVariant* result, bool allowPopups) = 0; > + And here too. > > +bool PluginView::evaluate(NPObject* npObject, const String &scriptString, NPVariant* result, bool allowPopups) > +{ And again. > + virtual bool evaluate(NPObject*, const WebCore::String &scriptString, NPVariant* result, bool allowPopups); Once more! r=me

Anders Carlsson

Comment 3 2010-07-30 14:44:24 PDT

Committed r64377: <http://trac.webkit.org/changeset/64377>

Note You need to log in before you can comment on or make changes to this bug.