Bug 43262

Summary: style errors in Navigator.h
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: WebCore Misc.Assignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch darin: review+

chris fleizach
Reported 2010-07-30 10:11:25 PDT
I want to modify Navigator.h but there are style errors. i'd like to resolve the style errors so my commit won't have them the style error is bad class identation
Attachments
Patch (3.17 KB, patch)
2010-07-30 10:16 PDT, chris fleizach 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
chris fleizach
Comment 1 2010-07-30 10:16:22 PDT
Created attachment 63073 [details] Patch
Darin Adler
Comment 2 2010-07-30 12:31:08 PDT
Comment on attachment 63073 [details] Patch Seems fine to chagne the indentation. > + ~Navigator(); This should be explicitly marked virtual. We prefer to do that explicitly even when we derive from a class where the destructor is already virtual.
chris fleizach
Comment 3 2010-07-30 14:14:25 PDT
http://trac.webkit.org/changeset/64371
Note You need to log in before you can comment on or make changes to this bug.