|Summary:||[Qt] Do not link to SharedBufferCF.cpp|
|Product:||WebKit||Reporter:||Markus Goetz <markus>|
|Component:||New Bugs||Assignee:||Markus Goetz <markus>|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Markus Goetz 2010-07-30 05:45:01 PDT
[Qt] Do not link to SharedBufferCF.cpp
Comment 1 Markus Goetz 2010-07-30 05:53:58 PDT
Patch coming soon..
Comment 3 WebKit Commit Bot 2010-07-30 09:02:02 PDT
Comment on attachment 63064 [details] Patch Rejecting patch 63064 from commit-queue. firstname.lastname@example.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact email@example.com to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights.
Comment 4 Tor Arne Vestbø 2010-07-30 09:06:00 PDT
Comment on attachment 63064 [details] Patch Let's look at this on monday. > + No new tests. (OOPS!) Also, this oops has to go
Comment 5 Markus Goetz 2010-07-30 09:07:57 PDT
Comment on attachment 63064 [details] Patch have to speak with Tor Arne first..
Comment 7 Kenneth Rohde Christiansen 2010-08-02 07:01:39 PDT
Comment on attachment 63213 [details] Patch LGTM
Comment 8 Kenneth Rohde Christiansen 2010-08-02 07:02:20 PDT
Comment on attachment 63213 [details] Patch Oh, sorry I see that you want to talk to Tor Arne first. Removing cq+
Comment 9 Markus Goetz 2010-08-02 07:31:19 PDT
Thanks kenneth. The TorArne thing was about the previous patch, the current one should be fine. So cq+ is great with me.
Comment 10 WebKit Commit Bot 2010-08-02 07:48:21 PDT
Comment on attachment 63213 [details] Patch Clearing flags on attachment: 63213 Committed r64461: <http://trac.webkit.org/changeset/64461>
Comment 11 WebKit Commit Bot 2010-08-02 07:48:26 PDT
All reviewed patches have been landed. Closing bug.