| Summary: | [Qt] Do not link to SharedBufferCF.cpp | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Markus Goetz <markus> | ||||||
| Component: | New Bugs | Assignee: | Markus Goetz <markus> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, hausmann | ||||||
| Priority: | P2 | Keywords: | Qt | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Markus Goetz
2010-07-30 05:45:01 PDT
Patch coming soon.. Created attachment 63064 [details]
Patch
Comment on attachment 63064 [details] Patch Rejecting patch 63064 from commit-queue. markus.goetz@nokia.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 63064 [details] Patch Let's look at this on monday. > + No new tests. (OOPS!) Also, this oops has to go Comment on attachment 63064 [details]
Patch
have to speak with Tor Arne first..
Created attachment 63213 [details]
Patch
Comment on attachment 63213 [details]
Patch
LGTM
Comment on attachment 63213 [details]
Patch
Oh, sorry I see that you want to talk to Tor Arne first. Removing cq+
Thanks kenneth. The TorArne thing was about the previous patch, the current one should be fine. So cq+ is great with me. Comment on attachment 63213 [details] Patch Clearing flags on attachment: 63213 Committed r64461: <http://trac.webkit.org/changeset/64461> All reviewed patches have been landed. Closing bug. |