Bug 43242

Summary:

[Qt] Do not link to SharedBufferCF.cpp

Product:

WebKit

Reporter:

Markus Goetz <markus>

Component:

New Bugs

Assignee:

Markus Goetz <markus>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hausmann

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none

Markus Goetz

Reported 2010-07-30 05:45:01 PDT

[Qt] Do not link to SharedBufferCF.cpp

Attachments
Patch (1.10 KB, patch) 2010-07-30 08:59 PDT, Markus Goetz	no flags	Details Formatted Diff Diff
Patch (1.76 KB, patch) 2010-08-02 06:57 PDT, Markus Goetz	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Markus Goetz

Comment 1 2010-07-30 05:53:58 PDT

Patch coming soon..

Markus Goetz

Comment 2 2010-07-30 08:59:59 PDT

Created attachment 63064 [details] Patch

WebKit Commit Bot

Comment 3 2010-07-30 09:02:02 PDT

Comment on attachment 63064 [details] Patch Rejecting patch 63064 from commit-queue. markus.goetz@nokia.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights.

Tor Arne Vestbø

Comment 4 2010-07-30 09:06:00 PDT

Comment on attachment 63064 [details] Patch Let's look at this on monday. > + No new tests. (OOPS!) Also, this oops has to go

Markus Goetz

Comment 5 2010-07-30 09:07:57 PDT

Comment on attachment 63064 [details] Patch have to speak with Tor Arne first..

Markus Goetz

Comment 6 2010-08-02 06:57:15 PDT

Created attachment 63213 [details] Patch

Kenneth Rohde Christiansen

Comment 7 2010-08-02 07:01:39 PDT

Comment on attachment 63213 [details] Patch LGTM

Kenneth Rohde Christiansen

Comment 8 2010-08-02 07:02:20 PDT

Comment on attachment 63213 [details] Patch Oh, sorry I see that you want to talk to Tor Arne first. Removing cq+

Markus Goetz

Comment 9 2010-08-02 07:31:19 PDT

Thanks kenneth. The TorArne thing was about the previous patch, the current one should be fine. So cq+ is great with me.

WebKit Commit Bot

Comment 10 2010-08-02 07:48:21 PDT

Comment on attachment 63213 [details] Patch Clearing flags on attachment: 63213 Committed r64461: <http://trac.webkit.org/changeset/64461>

WebKit Commit Bot

Comment 11 2010-08-02 07:48:26 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.